-
Notifications
You must be signed in to change notification settings - Fork 221
Open
Description
In "adapters/p2p2core/class.go"
Please refactor AdaptClass (by renaming it to AdaptClassDefinition and:
- change the
adaptEPlambda function into a normal function (I think a similar function already exists which is calledadaptEntryPoint. - remove the use of
utils.mapand use a for-loop.
Rename createCompiledClass and name it compileToCasm:
- Change the return type from a reference type to a value type (*core.CasmClass
tocore.CasmClass`) - Add a
todoon top which asks: "should this be a method ofclass.Cairo1Class" - In order to get this change correct you will have to update
sn2coreAdaptCompiledClass.
In "adapters/p2p2core/transaction.go", change the return types of AdaptDeclareV3WithClass to return by value.
Metadata
Metadata
Assignees
Labels
No labels