Skip to content

Conversation

@MaksymMalicki
Copy link
Contributor

@MaksymMalicki MaksymMalicki commented Nov 20, 2025

This PR should be reviewed after #3282 . It aims to:

  • Move the State and Trie interfaces from commonstate and commontrie packages to core package and rename them to CommonState and CommonTrie. This way the circular imports in pending_state.go are omitted and there is no naming clash.
  • Use the CommonState and CommonTrie in Juno. Right now both old and new implementations of State and Trie use these interfaces. It is possible to utilise the new interfaces in Juno, but always feed the old implementations to them. The CMD flag, specifying which set of implementations to use will be introduced in the next PR.
  • Implement the missing CompiledClassHash() and CompiledClassHashV2() methods for the new State
  • Rename MockStateHistoryReader and all its methods to MockCommonState

The next PR to review: #3187

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 49.39759% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.31%. Comparing base (584e500) to head (21af273).

Files with missing lines Patch % Lines
rpc/mocks/mock_gateway_handler.go 0.00% 15 Missing ⚠️
core/state/state.go 0.00% 12 Missing ⚠️
core/state/history.go 42.85% 4 Missing ⚠️
core/history.go 0.00% 3 Missing ⚠️
core/pending_state.go 0.00% 3 Missing ⚠️
core/state/statefactory/state_factory.go 0.00% 3 Missing ⚠️
core/state.go 66.66% 1 Missing ⚠️
sync/sync.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3283      +/-   ##
==========================================
+ Coverage   76.20%   76.31%   +0.10%     
==========================================
  Files         346      346              
  Lines       32690    32649      -41     
==========================================
+ Hits        24912    24915       +3     
+ Misses       5987     5946      -41     
+ Partials     1791     1788       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MaksymMalicki MaksymMalicki force-pushed the maksym/common-interfaces-integration branch from ac44bab to 21af273 Compare December 5, 2025 13:14
@rodrigo-pino rodrigo-pino requested review from EgeCaner, infrmtcs and rodrigo-pino and removed request for EgeCaner and rodrigo-pino December 8, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants