refactor(trie2): use more descriptive felt.Hash type instead of felt.Felt

[MaksymMalicki]

This PR addresses #3282 (comment), and uses more descriptive felt.Hash type for trie node hash fields and felt.StateRootHash for all the state root hash fields in all triedb and trie2 packages

[codecov]

Codecov Report

❌ Patch coverage is 72.88136% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.21%. Comparing base (584e500) to head (0f9e3c1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
core/trie2/trie.go	28.57%	20 Missing ⚠️
core/trie2/triedb/pathdb/journal.go	37.50%	5 Missing ⚠️
core/trie2/databasetest.go	70.00%	3 Missing ⚠️
core/trie2/trieutils/accessors.go	50.00%	2 Missing ⚠️
core/trie2/triedb/hashdb/database.go	94.11%	1 Missing ⚠️
core/trie2/triedb/rawdb/database.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3316      +/-   ##
==========================================
+ Coverage   76.20%   76.21%   +0.01%     
==========================================
  Files         346      346              
  Lines       32690    32761      +71     
==========================================
+ Hits        24912    24970      +58     
- Misses       5987     5999      +12     
- Partials     1791     1792       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[rodrigo-pino]

felt.Hash is the most general type, but I think it is being miss-used.

felt.Hash means that there is not a good type to define it and it makes sense to be a general type, for example the return type of hashing function.

On the other hand, here we know the semantic meaning each hash has here, so we should use the appropriate types.

As far as I understand, it should be:

1. classNodes keys should be of type felt.ClassHash
2. contractNodes should be of type felt.Address since it is a contract address
3. contractStorageNodes should be of type felt.Address to felt.StorageAddress (or felt.StorageSlot). <- The latter types are to be defined

[MaksymMalicki]

I don't think its correct or I'm missing something here. In this particular example, The felt.Hash in the hashmap mimics the layertree, which maps state root -> trie nodeset. So the felt.Hash represents the state root. The trieutils.Path represents the class hash for class trie, address for contract trie and the storage slot for the contract storage tries

[rodrigo-pino]

I see, then I think we should have a StateRootHash

[rodrigo-pino]

Similar coment to the previous ones, what would be the right hash here?

[MaksymMalicki]

it's a mapping of child state root to the parent state root. Since its calculated from a few components using PoseidonHash (result of hashing function), I'd say it's correct or we introduce a special felt-like type for the state commitment

[rodrigo-pino]

I think here we could use StateRootHash again

[MaksymMalicki]

let me add it