fix: reduce db calls for getTransactionReceipt RPC #3320

brbrr · 2025-12-02T10:45:26Z

Copilot

Pull request overview

This PR optimizes the getTransactionReceipt RPC endpoint by reducing the number of database calls. Instead of making separate queries by transaction hash to get the transaction and receipt, it first retrieves the block number and index from the hash, then uses those coordinates to fetch the transaction and receipt directly. This reduces database lookups from potentially 3+ calls down to 3 calls (one for the index lookup, one for transaction, one for receipt).

Key changes:

Introduced new methods TxBlockNumberAndIndexByHash and ReceiptByBlockNumberAndIndex to enable block-coordinate-based lookups
Refactored TransactionReceiptByHash to use the new lookup pattern

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
rpc/v9/transaction.go	Updated `TransactionReceiptByHash` to use new block-coordinate-based lookup methods
blockchain/blockchain.go	Added `TxBlockNumberAndIndexByHash` and `ReceiptByBlockNumberAndIndex` methods to Reader interface
core/accessors.go	Added `GetReceiptByBlockNumIndex` helper function for direct receipt lookup by coordinates
mocks/mock_blockchain.go	Generated mock implementations for new Reader interface methods
rpc/v9/transaction_test.go	Updated all test expectations to use new method call patterns
rpc/v9/subscriptions_test.go	Updated subscription test expectations for new method calls
rpc/v9/l1_test.go	Updated L1 message status test expectations and fixed type inconsistencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

mocks/mock_blockchain.go

rpc/v9/transaction.go

rpc/v9/l1_test.go

blockchain/blockchain.go

Co-authored-by: Copilot <[email protected]> Signed-off-by: Yaroslav Kukharuk <[email protected]>

blockchain/blockchain.go

core/accessors.go

Co-authored-by: Dat Duong <[email protected]> Signed-off-by: Yaroslav Kukharuk <[email protected]>

codecov · 2025-12-02T16:33:39Z

Codecov Report

❌ Patch coverage is 32.65306% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.08%. Comparing base (8849d75) to head (c8b3a0f).

Files with missing lines	Patch %	Lines
blockchain/blockchain.go	0.00%	13 Missing ⚠️
core/accessors.go	0.00%	8 Missing ⚠️
rpc/v8/transaction.go	57.14%	4 Missing and 2 partials ⚠️
rpc/v10/transactions.go	42.85%	3 Missing and 1 partial ⚠️
rpc/v9/transaction.go	71.42%	1 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (32.65%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3320      +/-   ##
==========================================
- Coverage   76.18%   76.08%   -0.10%     
==========================================
  Files         347      347              
  Lines       32760    32792      +32     
==========================================
- Hits        24958    24951       -7     
- Misses       6014     6050      +36     
- Partials     1788     1791       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Yaroslav Kukharuk <[email protected]>

rodrigo-pino

Overview review, I am not sure I notice how we are doing less calls here

blockchain/blockchain.go

core/accessors.go

brbrr · 2025-12-05T23:39:21Z

Overview review, I am not sure I notice how we are doing less calls here

Based on my quick look, TransactionByHash reads from:

TransactionBlockNumbersAndIndicesByHashBucket
TransactionsByBlockNumberAndIndexBucket

Receipt reads from:

TransactionBlockNumbersAndIndicesByHashBucket
TransactionBlockNumbersAndIndicesByHashBucket
ReceiptsByBlockNumberAndIndexBucket
BlockHeadersByNumber

with this PR, non-pending request will read from:

TransactionBlockNumbersAndIndicesByHashBucket
TransactionsByBlockNumberAndIndexBucket
ReceiptsByBlockNumberAndIndexBucket
BlockHeadersByNumber

infrmtcs · 2025-12-09T15:04:56Z

core/accessors.go

+	var numIdxKey db.BlockNumIndexKey
+	numIdxKey.Number = num
+	numIdxKey.Index = index


Suggested change

var numIdxKey db.BlockNumIndexKey

numIdxKey.Number = num

numIdxKey.Index = index

numIdxKey := db.BlockNumIndexKey {

Number: num,

Index: index,

}

infrmtcs · 2025-12-09T15:05:18Z

core/accessors.go

+	receipt, err := ReceiptsByBlockNumberAndIndexBucket.Get(r, numIdxKey)
+	if err != nil {
+		return TransactionReceipt{}, err
+	}
+	return receipt, nil


Suggested change

receipt, err := ReceiptsByBlockNumberAndIndexBucket.Get(r, numIdxKey)

if err != nil {

return TransactionReceipt{}, err

}

return receipt, nil

return ReceiptsByBlockNumberAndIndexBucket.Get(r, numIdxKey)

infrmtcs · 2025-12-09T15:05:40Z

core/accessors.go

 }

+func GetReceiptByBlockNumIndex(
+	r db.KeyValueReader, num, index uint64,


nit:

Suggested change

r db.KeyValueReader, num, index uint64,

r db.KeyValueReader,

num,

index uint64,

infrmtcs · 2025-12-09T15:06:35Z

blockchain/blockchain.go

+// BlockNumberAndIndexByTxHash gets transaction block number and index by Tx hash
+func (b *Blockchain) BlockNumberAndIndexByTxHash(
+	hash *felt.TransactionHash,
+) (uint64, uint64, error) {


Although this is not required, I think this would help readability:

Suggested change

) (uint64, uint64, error) {

) (blockNumber uint64, txIndex uint64, returnedErr error) {

infrmtcs · 2025-12-09T15:08:41Z

rpc/v10/subscriptions_test.go

+			block.Number, uint64(0),
+		).Return(block.Transactions[0], nil)
+		mockChain.EXPECT().ReceiptByBlockNumberAndIndex(
+			block.Number, uint64(0)).Return(block.Receipts[0], block.Hash, nil)


nit: break line

infrmtcs · 2025-12-09T15:08:50Z

rpc/v10/subscriptions_test.go

+			(*felt.TransactionHash)(txHash),
+		).Return(block.Number, uint64(0), nil)
+		mockChain.EXPECT().TransactionByBlockNumberAndIndex(
+			block.Number, uint64(0)).Return(block.Transactions[0], nil)


nit: break line

update v9 and tests

8c125ae

brbrr self-assigned this Dec 2, 2025

Copilot AI review requested due to automatic review settings December 2, 2025 10:45

Copilot started reviewing on behalf of brbrr December 2, 2025 10:45 View session

Copilot finished reviewing on behalf of brbrr December 2, 2025 10:47

Copilot AI reviewed Dec 2, 2025

View reviewed changes

Apply suggestions from code review

d4c254f

Co-authored-by: Copilot <[email protected]> Signed-off-by: Yaroslav Kukharuk <[email protected]>

infrmtcs reviewed Dec 2, 2025

View reviewed changes

blockchain/blockchain.go Outdated Show resolved Hide resolved

infrmtcs reviewed Dec 2, 2025

View reviewed changes

core/accessors.go Outdated Show resolved Hide resolved

brbrr temporarily deployed to Development December 2, 2025 10:59 — with GitHub Actions Inactive

brbrr and others added 2 commits December 2, 2025 12:43

Apply suggestion from @infrmtcs

6a20c29

Co-authored-by: Dat Duong <[email protected]> Signed-off-by: Yaroslav Kukharuk <[email protected]>

update new method name

fed0185

brbrr temporarily deployed to Development December 2, 2025 13:33 — with GitHub Actions Inactive

brbrr added 2 commits December 2, 2025 15:20

use felt.TransactionHash

80f5190

v8 transaction and tests

30f03a7

brbrr temporarily deployed to Development December 2, 2025 16:30 — with GitHub Actions Inactive

Merge branch 'main' into update/reduce-db-calls-getTransactionReceipt

9cc6037

brbrr temporarily deployed to Development December 3, 2025 09:52 — with GitHub Actions Inactive

fix linting errors

24b0bc7

brbrr temporarily deployed to Development December 3, 2025 10:52 — with GitHub Actions Inactive

brbrr added 2 commits December 3, 2025 12:54

Merge branch 'main' into update/reduce-db-calls-getTransactionReceipt

e0ca771

Signed-off-by: Yaroslav Kukharuk <[email protected]>

apply the change to v10

8a23ebe

brbrr temporarily deployed to Development December 3, 2025 17:55 — with GitHub Actions Inactive

update styling to be inline with codebase

2a265c6

brbrr temporarily deployed to Development December 3, 2025 18:21 — with GitHub Actions Inactive

Merge branch 'main' into update/reduce-db-calls-getTransactionReceipt

d2ce1c8

brbrr temporarily deployed to Development December 4, 2025 11:49 — with GitHub Actions Inactive

rodrigo-pino reviewed Dec 5, 2025

View reviewed changes

blockchain/blockchain.go Outdated Show resolved Hide resolved

blockchain/blockchain.go Show resolved Hide resolved

core/accessors.go Outdated Show resolved Hide resolved

brbrr added 3 commits December 9, 2025 15:33

Merge branch 'main' into update/reduce-db-calls-getTransactionReceipt

3ad2039

address feedback

2facc99

small fix

c8b3a0f

brbrr temporarily deployed to Development December 9, 2025 15:04 — with GitHub Actions Inactive

infrmtcs reviewed Dec 9, 2025

View reviewed changes

	) (uint64, uint64, error) {
	) (blockNumber uint64, txIndex uint64, returnedErr error) {

fix: reduce db calls for getTransactionReceipt RPC #3320

Are you sure you want to change the base?

fix: reduce db calls for getTransactionReceipt RPC #3320

Uh oh!

Conversation

brbrr commented Dec 2, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rodrigo-pino left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brbrr commented Dec 5, 2025

Uh oh!

infrmtcs Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

infrmtcs Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

infrmtcs Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

infrmtcs Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

infrmtcs Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

infrmtcs Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Dec 2, 2025 •

edited

Loading