Skip to content

Commit 2fc0716

Browse files
Ericson2314roberth
andauthored
Apply suggestions from code review
Co-authored-by: Robert Hensing <[email protected]>
1 parent acfc3d1 commit 2fc0716

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

doc/manual/source/store/build-trace.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@
77
> and subject to change.
88
99
The *build trace* is a [memoization table](https://en.wikipedia.org/wiki/Memoization) for builds.
10-
It maps the the inputs of builds to the outputs of builds.
10+
It maps the inputs of builds to the outputs of builds.
1111
Concretely, that means it maps [derivations][derivation] to maps of [output] names to [store objects][store object].
1212

13-
In general the derivations used as a key should be be [*resolved*](./resolution.md).
13+
In general the derivations used as a key should be [*resolved*](./resolution.md).
1414
A build trace with all-resolved-derivation keys is also called a *base build trace* for extra clarity.
1515
If all the resolved inputs of a derivation are content-addressed, that means the inputs will be fully determined, leaving no ambiguity for what build was performed.
1616
(Input-addressed inputs however are still ambiguous. They too should be locked down, but this is left as future work.)

doc/manual/source/store/derivation/outputs/input-address.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ If the outputs are [content-addressed](./content-address.md), then it computes a
123123
> In the [fixed](./content-address.md#fixed) content-addressing case, the outputs' content addresses are statically specified in advance, so this always just works.
124124
> (The fixed case is what the pseudo-code shows.)
125125
>
126-
> In the [floating](./content-address.md#floating) case, the content addresses are not specified in advanced.
126+
> In the [floating](./content-address.md#floating) case, the content addresses are not specified in advance.
127127
> This is what the "or get from [build trace](@docroot@/store/build-trace.md) if floating" comment refers to.
128128
> In this case, the algorithm is *stuck* until the input in question is built, and we know what the actual contents of the output in question is.
129129
>
@@ -133,7 +133,7 @@ If the outputs are [content-addressed](./content-address.md), then it computes a
133133

134134
The recursion in the algorithm is potentially inefficient:
135135
it could call itself once for each path by which a subderivation can be reached, i.e., `O(V^k)` times for a derivation graph with `V` derivations and with out-degree of at most `k`.
136-
In the actual implementation, [memoisation]((https://en.wikipedia.org/wiki/Memoization) is used to reduce this cost to be proportional to the total number of `inputDrvOutputs` encountered.
136+
In the actual implementation, [memoisation](https://en.wikipedia.org/wiki/Memoization) is used to reduce this cost to be proportional to the total number of `inputDrvOutputs` encountered.
137137

138138
### Semantic properties
139139

0 commit comments

Comments
 (0)