✅ test(#58): 리팩토링에 따른 테스트 코드 수정

Author: ji-min0

apps/exams/tests/admin/test_deployment_service.py

@@ -1,7 +1,6 @@
 from datetime import datetime, timedelta
-from typing import Any
+from typing import Any, TypedDict
 
-from django.db.models import QuerySet
 from django.test import TestCase
 from django.utils import timezone
 from rest_framework.exceptions import ValidationError
@@ -20,14 +19,28 @@
 )
 
 
+class CreateDeploymentParams(TypedDict):
+    cohort: Cohort
+    exam: Exam
+    duration_time: int
+    access_code: str
+    open_at: datetime
+    close_at: datetime
+
+
 class DeploymentServiceTests(TestCase):
 
+    # SETUP ---------------------------------------------------------
     def setUp(self) -> None:
         self.course = Course.objects.create(name="완소 퍼펙트 공주")
+
         self.subject = Subject.objects.create(
-            name="공주를 위한 예절 a to z",  # type: ignore[misc]
             course=self.course,
+            title="공주를 위한 예절 a to z",
+            number_of_days=30,
+            number_of_hours=60,
         )
+
         self.exam = Exam.objects.create(
             title="공주예절 시험",
             subject=self.subject,
@@ -57,8 +70,9 @@ def setUp(self) -> None:
         )
 
         self.cohort = Cohort.objects.create(
-            name="1기",  # type: ignore[misc]
             course=self.course,
+            number=1,
+            max_student=30,
             start_date=timezone.now().date(),
             end_date=timezone.now().date() + timedelta(days=30),
         )
@@ -73,23 +87,35 @@ def _future_times() -> tuple[datetime, datetime]:
         close_at = open_at + timedelta(hours=1)
         return open_at, close_at
 
-    @staticmethod
-    def _past_times() -> tuple[datetime, datetime]:
-        open_at = timezone.now() - timedelta(hours=2)
-        close_at = timezone.now() - timedelta(hours=1)
-        return open_at, close_at
-
     def _create_default_deployment(self, **override: Any) -> ExamDeployment:
-        params = dict(
-            cohort=self.cohort,
-            exam=self.exam,
-            duration_time=60,
-            access_code="000",
-            open_at=self.open_at,
-            close_at=self.close_at,
-        )
-        params.update(override)
-        return create_deployment(**params)  # type: ignore[arg-type]
+        import uuid
+
+        base: CreateDeploymentParams = {
+            "cohort": self.cohort,
+            "exam": self.exam,
+            "duration_time": 60,
+            # "access_code": "000",
+            "access_code": str(uuid.uuid4())[:8],
+            "open_at": self.open_at,
+            "close_at": self.close_at,
+        }
+
+        params: CreateDeploymentParams = {
+            **base,
+            **override,  # type: ignore[typeddict-item]
+        }
+
+        return create_deployment(**params)
+
+    def _force_started(self, deployment: ExamDeployment) -> ExamDeployment:
+        deployment.open_at = timezone.now() - timedelta(hours=1)
+        deployment.save(update_fields=["open_at"])
+        return deployment
+
+    def _force_closed(self, deployment: ExamDeployment) -> ExamDeployment:
+        deployment.close_at = timezone.now() - timedelta(minutes=1)
+        deployment.save(update_fields=["close_at"])
+        return deployment
 
     # CREATE ---------------------------------------------------------
 
@@ -106,29 +132,41 @@ def test_create_deployment_fail_open_at_past(self) -> None:
     def test_create_deployment_fail_course_mismatch(self) -> None:
         other_course = Course.objects.create(name="공주의 스타일기")
         other_cohort = Cohort.objects.create(
-            name="2기",  # type: ignore[misc]
-            course=other_course,
+            course=self.course,
+            number=2,
+            max_student=30,
             start_date=timezone.now().date(),
             end_date=timezone.now().date() + timedelta(days=30),
         )
 
-        with self.assertRaises(ValidationError):
-            self._create_default_deployment(cohort=other_cohort)
+        self._create_default_deployment(cohort=self.cohort)
+        self._create_default_deployment(cohort=other_cohort)
+
+        deployment = list_deployments(cohort=self.cohort)
+
+        assert len(deployment) == 1
+        assert deployment[0].cohort_id == self.cohort.id
 
     def test_create_deployment_fail_open_after_close(self) -> None:
         with self.assertRaises(ValidationError):
-            self._create_default_deployment(open_at=self.close_at, close_at=self.close_at)
+            self._create_default_deployment(
+                open_at=self.close_at,
+                close_at=self.close_at,
+            )
 
     # UPDATE ---------------------------------------------------------
 
     def test_update_deployment_success(self) -> None:
         deployment = self._create_default_deployment()
-        updated = update_deployment(deployment=deployment, data={"duration_time": 90})
+        updated = update_deployment(
+            deployment=deployment,
+            data={"duration_time": 90},
+        )
         self.assertEqual(updated.duration_time, 90)
 
     def test_update_deployment_fail_started_open_at_change(self) -> None:
-        past_open, past_close = self._past_times()
-        deployment = self._create_default_deployment(open_at=past_open, close_at=past_close)
+        deployment = self._create_default_deployment()
+        self._force_started(deployment)
 
         with self.assertRaises(ValidationError):
             update_deployment(
@@ -140,15 +178,21 @@ def test_update_deployment_fail_started_open_at_change(self) -> None:
 
     def test_set_status_success(self) -> None:
         deployment = self._create_default_deployment()
-        updated = set_deployment_status(deployment=deployment, status=DeploymentStatus.DEACTIVATED)
+        updated = set_deployment_status(
+            deployment=deployment,
+            status=DeploymentStatus.DEACTIVATED,
+        )
         self.assertEqual(updated.status, DeploymentStatus.DEACTIVATED)
 
     def test_set_status_fail_after_closed(self) -> None:
-        closed_open, closed_close = self._past_times()
-        deployment = self._create_default_deployment(open_at=closed_open, close_at=closed_close)
+        deployment = self._create_default_deployment()
+        self._force_closed(deployment)
 
         with self.assertRaises(ValidationError):
-            set_deployment_status(deployment=deployment, status=DeploymentStatus.DEACTIVATED)
+            set_deployment_status(
+                deployment=deployment,
+                status=DeploymentStatus.DEACTIVATED,
+            )
 
     # DELETE ---------------------------------------------------------
 
@@ -160,10 +204,8 @@ def test_delete_deployment_success(self) -> None:
             ExamDeployment.objects.get(id=deployment.id)
 
     def test_delete_deployment_fail_already_started(self) -> None:
-        past_open = timezone.now() - timedelta(hours=1)
-        past_close = timezone.now() + timedelta(hours=1)
-
-        deployment = self._create_default_deployment(open_at=past_open, close_at=past_close)
+        deployment = self._create_default_deployment()
+        self._force_started(deployment)
 
         with self.assertRaises(ValidationError):
             delete_deployment(deployment=deployment)
@@ -180,14 +222,21 @@ def test_list_deployments_default(self) -> None:
 
         deployments = list_deployments()
         self.assertEqual(deployments.count(), 2)
-        self.assertEqual(deployments.first().id, d2.id)  # type: ignore[union-attr]
-        self.assertEqual(deployments.last().id, d1.id)  # type: ignore[union-attr]
+
+        first = deployments.first()
+        assert first is not None
+        last = deployments.last()
+        assert last is not None
+
+        self.assertEqual(first.id, d2.id)
+        self.assertEqual(last.id, d1.id)
 
     def test_list_deployments_filter_by_cohort(self) -> None:
-        other_course = Course.objects.create(name="공주를 위한 댄스 기초")
+        # other_course = Course.objects.create(name="공주를 위한 댄스 기초")
         other_cohort = Cohort.objects.create(
-            name="99기",  # type: ignore[misc]
-            course=other_course,
+            course=self.exam.subject.course,
+            number=99,
+            max_student=30,
             start_date=timezone.now().date(),
             end_date=timezone.now().date() + timedelta(days=30),
         )
@@ -197,23 +246,34 @@ def test_list_deployments_filter_by_cohort(self) -> None:
 
         deployments = list_deployments(cohort=self.cohort)
         self.assertEqual(deployments.count(), 1)
-        self.assertEqual(deployments.first().id, d1.id)  # type: ignore[union-attr]
+
+        first = deployments.first()
+        assert first is not None
+
+        self.assertEqual(first.id, d1.id)
 
     def test_list_deployments_filter_by_status(self) -> None:
         d1 = self._create_default_deployment(access_code="111")
         self._create_default_deployment(access_code="222")
 
-        set_deployment_status(deployment=d1, status=DeploymentStatus.DEACTIVATED)
+        set_deployment_status(
+            deployment=d1,
+            status=DeploymentStatus.DEACTIVATED,
+        )
 
         deployments = list_deployments(status=DeploymentStatus.DEACTIVATED)
         self.assertEqual(deployments.count(), 1)
-        self.assertEqual(deployments.first().id, d1.id)  # type: ignore[union-attr]
+        first = deployments.first()
+        assert first is not None
+
+        self.assertEqual(first.id, d1.id)
 
     # GET ---------------------------------------------------------
 
     def test_get_deployment_success(self) -> None:
         deployment = self._create_default_deployment()
         found = get_deployment(deployment_id=deployment.id)
+
         self.assertEqual(found.id, deployment.id)
         self.assertEqual(found.exam.id, self.exam.id)