Fnm/soft delete retention_policy #102
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit af0cda3. # Conflicts: # octopusdeploy_framework/datasource_lifecycle.go # octopusdeploy_framework/datasource_lifecycle_test.go # octopusdeploy_framework/resource_lifecycle.go # octopusdeploy_framework/resource_lifecycle_retention_test.go # octopusdeploy_framework/resource_lifecycle_test.go # octopusdeploy_framework/schemas/lifecycle.go
Rose-Northey
changed the title
Rose-Northey
changed the title
Rose-Northey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is not intended for direct merging without adding tests / tweaking - it demonstrates a working solution to the issue described below.
This should take place 6 months after the retention_with_policy block is marked as deprecated following this PR.
The
retention_policyis to be removed and replaced with a retention block which uses the new "strategy" attribute,retention_with_strategy. Due to deprecation requirements, both blocks must be available for use for 12 months before the old retention block can be officially deleted. This PR will makeretention_with_strategythe default retention block and soft delete theretention_policyblock. The user may use an environmental variable to go back to using either retention block again. The code in this PR is step 3 of the process below.Another 6 months after this soft delete, a permanent delete should be made which will make the
retention_policyblock inaccessible to all.sc-123783
PR #3
Relates to #104
Relates to #103
Note
This is a working solution however testing will need to be added. Environmental variables can be set in the tf testing environment using:
