Harden some CollectionMetadata/CubeMetadata usage

see also #464

Author: soxofaan

openeo/extra/spectral_indices/spectral_indices.py

@@ -4,6 +4,7 @@
 from typing import Dict, List, Optional, Set
 
 from openeo import BaseOpenEoException
+from openeo.metadata import CollectionMetadata
 from openeo.processes import ProcessBuilder, array_create, array_modify
 from openeo.rest.datacube import DataCube
 
@@ -273,7 +274,7 @@ def compute_and_rescale_indices(
         # Automatic band mapping
         band_mapping = _BandMapping()
         if platform is None:
-            if datacube.metadata and datacube.metadata.get("id"):
+            if isinstance(datacube.metadata, CollectionMetadata) and datacube.metadata.get("id"):
                 platform = band_mapping.guess_platform(name=datacube.metadata.get("id"))
             else:
                 raise BandMappingException("Unable to determine satellite platform from data cube metadata")

openeo/metadata.py

@@ -488,6 +488,7 @@ def resample_spatial(
     def resample_cube_spatial(self, target: CubeMetadata) -> CubeMetadata:
         return self._clone_and_update(dimensions=list(target._dimensions))
 
+
 class CollectionMetadata(CubeMetadata):
     """
     Wrapper for EO Data Collection metadata.

openeo/rest/datacube.py

@@ -157,7 +157,7 @@ def process_with_node(self, pg: PGNode, metadata: Optional[CollectionMetadata] =
 
     def _do_metadata_normalization(self) -> bool:
         """Do metadata-based normalization/validation of dimension names, band names, ..."""
-        return isinstance(self.metadata, CollectionMetadata)
+        return isinstance(self.metadata, CubeMetadata)
 
     def _assert_valid_dimension_name(self, name: str) -> str:
         if self._do_metadata_normalization():