fixup! Issue #793/#794 preserve "item_id" column for now

Author: soxofaan

tests/extra/job_management/test_stac_job_db.py

@@ -166,19 +166,14 @@ def dummy_stac_item() -> pystac.Item:
     )
 
 
-@pytest.fixture
-def dummy_series_no_item_id() -> pd.Series:
-    return pd.Series({"datetime": "2020-05-22T00:00:00Z", "some_property": "value"}, name="test")
-
-
 
 @pytest.fixture
 def bulk_dataframe():
     return pd.DataFrame(
-        index=[f"test-{i}" for i in range(10)],
+        index=[f"item-{i}" for i in range(10)],
         data={
+            "datetime": [f"2020-{i + 1:02d}-01" for i in range(10)],
             "some_property": [f"value-{i}" for i in range(10)],
-            "datetime": [f"2020-{i+1:02d}-01" for i in range(10)],
         },
     )
 
@@ -295,8 +290,25 @@ def test_initialize_from_df_with_geometry(self, mock_persists, job_db_not_exists
         assert job_db_not_exists.has_geometry == True
         assert job_db_not_exists.geometry_column == "geometry"
 
-    def test_series_from(self, job_db_exists, dummy_series_no_item_id, dummy_stac_item):
-        pdt.assert_series_equal(job_db_exists.series_from(dummy_stac_item), dummy_series_no_item_id)
+    @pytest.mark.parametrize(
+        ["item", "expected"],
+        [
+            (
+                _pystac_item(
+                    id="item-123",
+                    properties={"some_property": "value"},
+                    datetime_=datetime.datetime(2020, 5, 22),
+                ),
+                pd.Series(
+                    name="item-123",
+                    data={"some_property": "value", "datetime": "2020-05-22T00:00:00Z"},
+                ),
+            ),
+        ],
+    )
+    def test_series_from(self, job_db_exists, item, expected):
+        actual = job_db_exists.series_from(item)
+        pdt.assert_series_equal(actual, expected)
 
     @pytest.mark.parametrize(
         ["series", "expected"],