remove item_id from STAC items

Author: HansVRP

openeo/extra/job_management/stac_job_db.py

@@ -139,6 +139,7 @@ def item_from(self, series: pd.Series) -> pystac.Item:
         """
         series_dict = series.to_dict()
         item_id = str(series.name)
+        series_dict.pop("item_id", None)
         item_dict = {}
         item_dict.setdefault("stac_version", pystac.get_stac_version())
         item_dict.setdefault("type", "Feature")

tests/extra/job_management/test_stac_job_db.py

@@ -90,7 +90,7 @@ def normalized_dummy_dataframe() -> pd.DataFrame:
         },
     )
     # Match new normalize_df behavior: set index to item_id (string) and name it
-    df.index = df["item_id"].astype(str)
+    df.index = df["item_id"]
     df.index.name = "item_id"
     return df
 
@@ -99,7 +99,7 @@ def normalized_dummy_dataframe() -> pd.DataFrame:
 def another_dummy_dataframe() -> pd.DataFrame:
     df =  pd.DataFrame({"item_id": ["1"], "no": [4], "geometry": [5], "here": [6]})
     # Match new normalize_df behavior: set index to item_id (string) and name it
-    df.index = df["item_id"].astype(str)
+    df.index = df["item_id"]
     df.index.name = "item_id"
     return df
 
@@ -126,7 +126,7 @@ def normalized_merged_dummy_dataframe() -> pd.DataFrame:
 
     # Match new normalize_df behavior: set index to item_id (string) and name it
 
-    df.index = df["item_id"].astype(str)
+    df.index = df["item_id"]
     df.index.name = "item_id"
     return df
 
@@ -147,7 +147,7 @@ def dummy_geodataframe() -> gpd.GeoDataFrame:
 def normalized_dummy_geodataframe() -> pd.DataFrame:
     df =  pd.DataFrame(
         {
-            "item_id": [0],
+            "item_id": ["0"],
             "there": [1],
             "is": [2],
             "geometry": [{"type": "Point", "coordinates": (1.0, 1.0)}],
@@ -163,7 +163,7 @@ def normalized_dummy_geodataframe() -> pd.DataFrame:
         }
     )
     # Match new normalize_df behavior: set index to item_id (string) and name it
-    df.index = df["item_id"].astype(str)
+    df.index = df["item_id"]
     df.index.name = "item_id"
     return df