Skip to content

Commit babf36b

Browse files
crabshellmandest1n1s
authored andcommitted
feat(activation):enable aligned permutation of crossmodel gen
This is achieved via setting same seeds for randperm generators and making sure they all lie in cuda device
1 parent 57de36b commit babf36b

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/lm_saes/activation/factory.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ def build_batchler():
207207
"""Create batchler for batched-activations-1d target."""
208208
assert cfg.batch_size is not None, "Batch size must be provided for outputting batched-activations-1d"
209209
return ActivationBatchler(
210-
hook_points=cfg.hook_points, batch_size=cfg.batch_size, buffer_size=cfg.buffer_size, buffer_shuffle_config=cfg.buffer_shuffle_config
210+
hook_points=cfg.hook_points, batch_size=cfg.batch_size, buffer_size=cfg.buffer_size, buffer_shuffle_config=cfg.buffer_shuffle
211211
)
212212

213213
processors = [build_batchler()] if cfg.target >= ActivationFactoryTarget.BATCHED_ACTIVATIONS_1D else []

src/lm_saes/config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ class ActivationFactoryConfig(BaseConfig):
261261
else None
262262
)
263263
""" Buffer size for online shuffling. If `None`, no shuffling will be performed. """
264-
buffer_shuffle_config: Optional[BufferShuffleConfig] = None
264+
buffer_shuffle: Optional[BufferShuffleConfig] = None
265265
"""" Manual seed and device of generator for generating randomperm in buffer. """
266266
ignore_token_ids: Optional[list[int]] = None
267267
""" Tokens to ignore in the activations. """

src/lm_saes/runner.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ class GenerateActivationsSettings(BaseSettings):
125125
buffer_size: Optional[int] = None
126126
"""Size of the buffer for activation generation"""
127127

128-
buffer_shuffle_config: Optional[BufferShuffleConfig] = None
128+
buffer_shuffle: Optional[BufferShuffleConfig] = None
129129
""""Manual seed and device of generator for generating randomperm in buffer"""
130130

131131
total_tokens: Optional[int] = None
@@ -202,7 +202,7 @@ def generate_activations(settings: GenerateActivationsSettings) -> None:
202202
model_batch_size=settings.model_batch_size,
203203
batch_size=settings.batch_size,
204204
buffer_size=settings.buffer_size,
205-
buffer_shuffle_config=settings.buffer_shuffle_config,
205+
buffer_shuffle=settings.buffer_shuffle,
206206
)
207207

208208
# Configure activation writer

0 commit comments

Comments
 (0)