Fix batch size validation for data parallelism and adjust total count for activation processing in CachedActivationLoader #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the batch size validation logic in `ActivationBatchler` to account for the data dimension size, ensuring consistent shapes across tensors and lists. - Improved assertion error messages to provide clearer feedback on batch size discrepancies.
…edActivationLoader - Updated the total count in the `tqdm` progress bar to account for the device mesh size, ensuring accurate progress tracking during activation chunk processing.
dest1n1s
approved these changes
Jul 7, 2025
dest1n1s
added a commit
that referenced
this pull request
Nov 8, 2025
Fix batch size validation for data parallelism and adjust total count for activation processing in CachedActivationLoader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActivationBatchlerto account for the data dimension size, ensuring consistent shapes across tensors and lists.tqdmprogress bar to account for the device mesh size, ensuring accurate progress tracking during activation chunk processing.