Update app/code/core/Mage/Api2/Exception.php

kiatng · sreichel · web-flow · commit b0be4bedc056 · 2025-07-07T10:04:37.000+08:00
Co-authored-by: Sven Reichel &lt;github-sr@hotmail.com&gt;
diff --git a/app/code/core/Mage/Api2/Exception.php b/app/code/core/Mage/Api2/Exception.php
@@ -39,11 +39,9 @@ public function __construct($message, $code, $shouldLog = true)
 
     /**
      * Check if exception should be logged
-     *
-     * @return bool
      */
-    public function shouldLog()
+    public function shouldLog(): bool
     {
-        return $this->_shouldLog;
+        return $this->shouldLog;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -39,11 +39,9 @@ public function __construct($message, $code, $shouldLog = true)`
`39`	`39`
`40`	`40`	`/**`
`41`	`41`	`* Check if exception should be logged`
`42`		`- *`
`43`		`- * @return bool`
`44`	`42`	`*/`
`45`		`- public function shouldLog()`
	`43`	`+ public function shouldLog(): bool`
`46`	`44`	`{`
`47`		`- return $this->_shouldLog;`
	`45`	`+ return $this->shouldLog;`
`48`	`46`	`}`
`49`	`47`	`}`