-
Notifications
You must be signed in to change notification settings - Fork 64
railway_manager_interface: update openapi #14283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Khoyo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"update openapi" is not an acceptable commit message, see https://osrd.fr/en/docs/guides/contribute/contribute-code/commit-conventions/
| hazardous_materials: | ||
| type: boolean | ||
| title: Hazardous Materials | ||
| train_category: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gesico train category, the user has to select: "A", "B", "C" or "Sans catégorie"
Should we rename it demand_category or circulation_category ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
demand_category sounds okay for me.
If I remember right, in the corresponding feature ticket, we talked about renaming the variants of the enum to be more meaningful.
ca655ae to
3b2b717
Compare
…anterior and posterior train, add demand category and hazardous materials Signed-off-by: Jules Peignier <[email protected]>
3b2b717 to
390a6e2
Compare
flomonster
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT (I just wonder about the enum variants of demand_category)
Khoyo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, that'd be railway_manager_interface: change openapi to allow substitute train, railway_manager_interface: change openapi to select anterior and posterior train, and railway_manager_interface: change openapi to add demand category and hazardous materials. But oh well
I chose |
The railway manager's OpenAPI interface must be updated to take into account the new entries: