Skip to content

Conversation

@JulesPeignier
Copy link
Contributor

@JulesPeignier JulesPeignier commented Dec 3, 2025

The railway manager's OpenAPI interface must be updated to take into account the new entries:

  • The user must be able to link a posterior train and/or an anterior train.
  • The user can select the train category.
  • The user can specify whether there are any hazardous materials.
  • The user can request to substitute a train, specifying the train name and departure date.

@JulesPeignier JulesPeignier requested review from a team as code owners December 3, 2025 11:22
@JulesPeignier JulesPeignier requested a review from Khoyo December 3, 2025 11:22
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 3, 2025
Copy link
Contributor

@Khoyo Khoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"update openapi" is not an acceptable commit message, see https://osrd.fr/en/docs/guides/contribute/contribute-code/commit-conventions/

hazardous_materials:
type: boolean
title: Hazardous Materials
train_category:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gesico train category, the user has to select: "A", "B", "C" or "Sans catégorie"

Should we rename it demand_category or circulation_category ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

demand_category sounds okay for me.

If I remember right, in the corresponding feature ticket, we talked about renaming the variants of the enum to be more meaningful.

@JulesPeignier JulesPeignier force-pushed the jules/railway-manager-openapi branch 2 times, most recently from ca655ae to 3b2b717 Compare December 4, 2025 14:18
…anterior and posterior train, add demand category and hazardous materials

Signed-off-by: Jules Peignier <[email protected]>
@JulesPeignier JulesPeignier force-pushed the jules/railway-manager-openapi branch from 3b2b717 to 390a6e2 Compare December 4, 2025 14:21
Copy link
Member

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT (I just wonder about the enum variants of demand_category)

Copy link
Contributor

@Khoyo Khoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, that'd be railway_manager_interface: change openapi to allow substitute train, railway_manager_interface: change openapi to select anterior and posterior train, and railway_manager_interface: change openapi to add demand category and hazardous materials. But oh well

@JulesPeignier
Copy link
Contributor Author

LGMT (I just wonder about the enum variants of demand_category)

I chose string because I think an enum would be too SNCF-specific

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:front Work on Standard OSRD Interface modules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants