Skip to content

Commit 9a2420f

Browse files
flichtenheldcron2
authored andcommitted
CMake: For VS build, switch from /W2 to /W3
But exclude the added checks that currently have failures so that we can keep /WX enabled. Basically this excludes -Wconversion and -Wsign-compare, as expected from our GCC/Clang flags. Github: #382 Change-Id: Iffc114939cb37129057e9c4864fae9e09c3c7fe4 Signed-off-by: Frank Lichtenheld <[email protected]> Acked-by: Gert Doering <[email protected]> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1417 Message-Id: <[email protected]> URL: https://www.mail-archive.com/[email protected]/msg34876.html Signed-off-by: Gert Doering <[email protected]>
1 parent bd8d03e commit 9a2420f

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

CMakeLists.txt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,12 @@ if (MSVC)
8585
if (USE_WERROR)
8686
add_compile_options(/WX)
8787
endif ()
88+
# C4018: signed/unsigned mismatch
89+
# C4244: conversion from 'type1' to 'type2', possible loss of data
90+
# C4267: conversion from 'size_t' to 'type', possible loss of data
8891
add_compile_options(
8992
/MP
90-
/W2
93+
/W3 /wd4018 /wd4267 /wd4244
9194
/sdl
9295
/Qspectre
9396
/guard:cf

0 commit comments

Comments
 (0)