add mac to the connectivity csv section of robo-diag (#19971)

# Overview

Adds an output of the robots WiFi and Ethernet MAC addresses to the
Robot diagnostics QC script.

Customers have requested the ability to know the MAC address of their
robot before they receive it or set it up. By logging the MAC address in
the output of the diagnostic scripts we can now look up the MAC address
of a robot based on it's serial number in our production database.

## Test Plan and Hands on Testing

Ran the test script on a Flex in the office. Checked that the MAC
addresses were contained in the output CSV.

## Changelog

Modifies the connectivity section of the flex diagnostics QC script in
hardware testing to add wifi and ethernet mac address outputs.

## Review requests



## Risk assessment

Minimal only impacts hardware testing code

Co-authored-by: Ryan Howard <[email protected]>

Author: 2 people

hardware-testing/hardware_testing/production_qc/robot_assembly_qc_ot3/test_connectivity.py

@@ -177,25 +177,29 @@ async def _test_ethernet(api: OT3API, report: CSVReport, section: str) -> None:
         ui.get_user_ready("connect ethernet cable")
         ethernet_status = await nmcli.iface_info(nmcli.NETWORK_IFACES.ETH_LL)
         eth_ip = ethernet_status["ipAddress"]
+        eth_mac = ethernet_status["macAddress"]
     else:
         eth_ip = "0.0.0.0"
+        eth_mac = "AA:AA:AA:AA:AA:AA"
     result = CSVResult.from_bool(bool(eth_ip))
-    report(section, "ethernet", [eth_ip, result])
+    report(section, "ethernet", [eth_ip, eth_mac, result])
 
 
 async def _test_wifi(report: CSVReport, section: str) -> None:
     ssid = ""
     password: Optional[str] = None
     result: Optional[CSVResult] = CSVResult.FAIL
     wifi_ip: Optional[str] = None
+    wifi_mac: Optional[str] = None
 
     def _finish() -> None:
-        report(section, "wifi", [ssid, password, wifi_ip, result])
+        report(section, "wifi", [ssid, password, wifi_ip, wifi_mac, result])
 
     LOG.info(f"System Architecture: {config.ARCHITECTURE}")
     try:
         wifi_status = await nmcli.iface_info(nmcli.NETWORK_IFACES.WIFI)
         wifi_ip = wifi_status["ipAddress"]
+        wifi_mac = wifi_status["macAddress"]
         if wifi_ip:
             result = CSVResult.PASS
             return _finish()
@@ -366,8 +370,8 @@ def build_csv_lines() -> List[Union[CSVLine, CSVLineRepeating]]:
     ]
     can_tests = [CSVLine(t, [CSVResult]) for t in AUX_CAN_TESTS]
     other_tests = [
-        CSVLine("ethernet", [str, CSVResult]),
-        CSVLine("wifi", [str, str, str, CSVResult]),
+        CSVLine("ethernet", [str, str, CSVResult]),
+        CSVLine("wifi", [str, str, str, str, CSVResult]),
         CSVLine("usb-b-rear", [CSVResult]),
     ]
     return other_tests + usb_a_tests + aux_tests + can_tests  # type: ignore[return-value]
@@ -384,7 +388,9 @@ async def run(api: OT3API, report: CSVReport, section: str) -> None:
     if not api.is_simulator:
         await _test_wifi(report, section)
     else:
-        report(section, "wifi", ["", "", "0.0.0.0", CSVResult.PASS])
+        report(
+            section, "wifi", ["", "", "0.0.0.0", "AA:AA:AA:AA:AA:AA", CSVResult.PASS]
+        )
         assert nmcli.iface_info is not None
         assert nmcli.configure is not None
         assert nmcli.wifi_disconnect is not None