Remove obsolete IActionContextAccessor in WorkflowTypeStep

Author: agriffard

src/OrchardCore.Modules/OrchardCore.Workflows/Recipes/WorkflowTypeStep.cs

@@ -1,9 +1,10 @@
 using System.Text.Json;
 using System.Text.Json.Nodes;
+using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Mvc;
-using Microsoft.AspNetCore.Mvc.Infrastructure;
 using Microsoft.AspNetCore.Mvc.Routing;
 using Microsoft.Extensions.Options;
+using OrchardCore.DisplayManagement.Extensions;
 using OrchardCore.Json;
 using OrchardCore.Recipes.Models;
 using OrchardCore.Recipes.Services;
@@ -19,28 +20,28 @@ public sealed class WorkflowTypeStep : NamedRecipeStepHandler
 {
     private readonly IWorkflowTypeStore _workflowTypeStore;
     private readonly ISecurityTokenService _securityTokenService;
-    private readonly IActionContextAccessor _actionContextAccessor;
+    private readonly IHttpContextAccessor _httpContextAccessor;
     private readonly IUrlHelperFactory _urlHelperFactory;
     private readonly JsonSerializerOptions _jsonSerializerOptions;
 
     public WorkflowTypeStep(IWorkflowTypeStore workflowTypeStore,
         ISecurityTokenService securityTokenService,
-        IActionContextAccessor actionContextAccessor,
+        IHttpContextAccessor httpContextAccessor,
         IUrlHelperFactory urlHelperFactory,
         IOptions<DocumentJsonSerializerOptions> jsonSerializerOptions)
         : base("WorkflowType")
     {
         _workflowTypeStore = workflowTypeStore;
         _securityTokenService = securityTokenService;
-        _actionContextAccessor = actionContextAccessor;
+        _httpContextAccessor = httpContextAccessor;
         _urlHelperFactory = urlHelperFactory;
         _jsonSerializerOptions = jsonSerializerOptions.Value.SerializerOptions;
     }
 
     protected override async Task HandleAsync(RecipeExecutionContext context)
     {
         var model = context.Step.ToObject<WorkflowStepModel>();
-        var urlHelper = GetUrlHelper();
+        var urlHelper = await GetUrlHelperAsync();
 
         foreach (var token in model.Data.Cast<JsonObject>())
         {
@@ -76,12 +77,14 @@ protected override async Task HandleAsync(RecipeExecutionContext context)
 
     private IUrlHelper _urlHelper;
 
-    private IUrlHelper GetUrlHelper()
+    private async Task<IUrlHelper> GetUrlHelperAsync()
     {
-        // When 'UrlHelper' is instantiated outside a controller's action (e.g., in a BackgroundTask), the ActionContext is null.
-        if (_urlHelper is null && _actionContextAccessor.ActionContext is not null)
+        // In .NET 10, IActionContextAccessor is obsolete, so we create ActionContext directly
+        if (_urlHelper is null && _httpContextAccessor.HttpContext is not null)
         {
-            _urlHelper = _urlHelperFactory.GetUrlHelper(_actionContextAccessor.ActionContext);
+            var httpContext = _httpContextAccessor.HttpContext;
+            var actionContext = await httpContext.GetActionContextAsync();
+            _urlHelper = _urlHelperFactory.GetUrlHelper(actionContext);
         }
 
         return _urlHelper;