`t9.t` bus error on Apple Silicon on GitHub Actions

[mohawk2]

This necessitated 6b6721e. I highly doubt this is unique to Apple Silicon, and some valgrind will probably reveal the problem.

[kiwiroy]

Not sure where the -lgcc_ext.10.5 -lgcc_s.10.5 is from.

t/00-report-prereqs.t .. ok   
t/eu-f77-dump.t ........ 2/?
# Method: runtime, "-L/opt/local/lib/gcc14/gcc/aarch64-apple-darwin24/14.2.0/../../.." -L/usr/lib -lgfortran -lgcc_ext.10.5 -lgcc_s.10.5 -lquadmath -lm
# Method: trail_, 1
# Method: compiler, aarch64-apple-darwin24-gfortran-mp-14
# Method: cflags,  
t/eu-f77-dump.t ........ ok   
t/lut.t ................ ok   
t/pdl-graphics.t ....... ok    
t/t1.t ................. # Using device '/NULL' - set env var PGPLOT_DEV to change
t/t1.t ................. ok   
t/t10.t ................ ok   
t/t11.t ................ ok   
t/t12.t ................ No subtests run 
t/t2.t ................. ok   
t/t3.t ................. ok   
t/t4.t ................. ok   
t/t5.t ................. ok   
t/t6.t ................. ok   
t/t7.t ................. ok   
t/t8.t ................. ok   
t/t9.t ................. No subtests run 

Test Summary Report
-------------------
t/t12.t              (Wstat: 11 (Signal: SEGV) Tests: 0 Failed: 0)
  Non-zero wait status: 11
  Parse errors: No plan found in TAP output
t/t9.t               (Wstat: 10 (Signal: BUS) Tests: 0 Failed: 0)
  Non-zero wait status: 10
  Parse errors: No plan found in TAP output
Files=16, Tests=58,  2 wallclock secs ( 0.02 usr  0.01 sys +  0.46 cusr  0.15 csys =  0.64 CPU)
Result: FAIL
Failed 2/16 test programs. 0/58 subtests failed.

[mohawk2]

Thanks. Please could you run this under lldb and give me a stack trace?

[kiwiroy]

Stack traces for #15 and #17

t/t9.t

$ lldb /opt/perlbrew/perls/perl-5.38.3/bin/perl -- -I./blib/lib -I./blib/arch t/t9.t 
(lldb) target create "/opt/perlbrew/perls/perl-5.38.3/bin/perl"
Current executable set to '/opt/perlbrew/perls/perl-5.38.3/bin/perl' (arm64).
(lldb) settings set -- target.run-args  "-I./blib/lib" "-I./blib/arch" "t/t9.t"
(lldb) run
Process 23683 launched: '/opt/perlbrew/perls/perl-5.38.3/bin/perl' (arm64)
# Testing PGPLOT 5.0 colour image routines
# 32768 bytes read
# 16384 element image stored
# Plotting...
Process 53152 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=2, address=0x1005c0000)
    frame #0: 0x000000019c842b48 libsystem_platform.dylib`_platform_memmove + 280
libsystem_platform.dylib`_platform_memmove:
->  0x19c842b48 <+280>: stnp   q0, q1, [x3]
    0x19c842b4c <+284>: add    x3, x3, #0x20
    0x19c842b50 <+288>: ldp    q0, q1, [x1]
    0x19c842b54 <+292>: add    x1, x1, #0x20
Target 0: (perl) stopped.
(lldb) bt
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=2, address=0x1005c0000)
  * frame #0: 0x000000019c842b48 libsystem_platform.dylib`_platform_memmove + 280
    frame #1: 0x0000000100542c60 PGPLOT.bundle`pgconl_ at pgconl.f:82:72
    frame #2: 0x00000001005343a4 PGPLOT.bundle`cpgconl(a=<unavailable>, idim=128, jdim=128, i1=1, i2=128, j1=1, j2=128, c=-1, tr=0x000060000296c1a0, label="-1", intval=200, minint=100) at cpgplot.c:107:3 [opt]
    frame #3: 0x0000000100527258 PGPLOT.bundle`XS_PGPLOT_pgconl(cv=<unavailable>) at PGPLOT.xs:257:5 [opt]
    frame #4: 0x00000001000e91a0 perl`Perl_pp_entersub + 2624
    frame #5: 0x00000001000ddcb8 perl`Perl_runops_standard + 32
    frame #6: 0x0000000100026a14 perl`S_run_body + 204
    frame #7: 0x0000000100026840 perl`perl_run + 708
    frame #8: 0x00000001000009a4 perl`main + 164
    frame #9: 0x000000019c48c274 dyld`start + 2840
(lldb)

debugging further

(lldb) breakpoint set -f cpgplot.c -l 107
(lldb) run
...
Process 53617 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = breakpoint 1.1
    frame #0: 0x000000010053436c PGPLOT.bundle`cpgconl(a=0x00000001280c8000, idim=128, jdim=128, i1=1, i2=128, j1=1, j2=128, c=-1, tr=0x0000600000bb5780, label="-1", intval=200, minint=100) at cpgplot.c:107:3 [opt]
   104   void cpgconl(const float *a, int idim, int jdim, int i1, int i2, int j1, int j2, float c, const float *tr, const char *label, int intval, int minint)
   105   {
   106     int len_label = strlen(label);
-> 107     pgconl_((float *)a, &idim, &jdim, &i1, &i2, &j1, &j2, &c, (float *)tr, (char *)label, &intval, &minint, len_label);
   108   }
   109   #include "cpgplot.h"
   110   extern void pgcons_();
Target 0: (perl) stopped.
warning: PGPLOT.bundle was compiled with optimization - stepping may behave oddly; variables may not be available.
(lldb) p label
(const char *) 0x00006000009b1610 "-1"

t/t12.t

$ lldb /opt/perlbrew/perls/perl-5.38.3/bin/perl -- -I./blib/lib -I./blib/arch t/t12.t 
(lldb) target create "/opt/perlbrew/perls/perl-5.38.3/bin/perl"
Current executable set to '/opt/perlbrew/perls/perl-5.38.3/bin/perl' (arm64).
(lldb) settings set -- target.run-args  "-I./blib/lib" "-I./blib/arch" "t/t12.t"
(lldb) run
Process 23706 launched: '/opt/perlbrew/perls/perl-5.38.3/bin/perl' (arm64)
# Testing some new PGPLOT 5.2.0 routines
# 32768 bytes read
# 16384 element image stored
# Plotting
Process 53179 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x6001036518b6)
    frame #0: 0x00000001007ce844 libgfortran.5.dylib`_gfortran_string_len_trim + 84
libgfortran.5.dylib`_gfortran_string_len_trim:
->  0x1007ce844 <+84>: ldrsb  w5, [x4, x3]
    0x1007ce848 <+88>: cmp    w5, #0x20
    0x1007ce84c <+92>: b.eq   0x1007ce858    ; <+104>
    0x1007ce850 <+96>: add    x0, x2, #0x1
Target 0: (perl) stopped.
(lldb) bt
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x6001036518b6)
  * frame #0: 0x00000001007ce844 libgfortran.5.dylib`_gfortran_string_len_trim + 84
    frame #1: 0x0000000100550540 PGPLOT.bundle`pgtick_ at pgtick.f:77:10
    frame #2: 0x0000000100535278 PGPLOT.bundle`cpgtick(x1=12500, y1=12800, x2=12900, y2=12100, v=0.349999994, tikl=3, tikr=5, disp=6, orient=90, str="pgperl!") at cpgplot.c:789:3 [opt]
    frame #3: 0x0000000100532a44 PGPLOT.bundle`XS_PGPLOT_pgtick(cv=<unavailable>) at PGPLOT.xs:1465:5 [opt]
    frame #4: 0x00000001000e91a0 perl`Perl_pp_entersub + 2624
    frame #5: 0x00000001000ddcb8 perl`Perl_runops_standard + 32
    frame #6: 0x0000000100026a14 perl`S_run_body + 204
    frame #7: 0x0000000100026840 perl`perl_run + 708
    frame #8: 0x00000001000009a4 perl`main + 164
    frame #9: 0x000000019c48c274 dyld`start + 2840
(lldb) 

investigating compiler warnings

Environment:

• arm 64
• gcc 14
• macports
• F77=aarch64-apple-darwin24-gfortran-mp-14
• Alien::PGPLOT initially, before manually compiling and installing to the same local/lib/perl5
  • : autotool version from djerius ; cd pgplot-5.2.2-9
  • ./configure --prefix=$(pwd)/local/lib/perl5/darwin-2level/auto/share/dist/Alien-PGPLOT --with-pic --disable-shared
  • make install CFLAGS='-g -Wall -Wpedantic' FFLAGS='-g -Wall -Wpedantic'
  • make install

Compiling pgplot with CFLAGS=-Wall -Wpedantic and FFLAGS=-Wall provides the following classes of warnings.

   7 -Wcharacter-truncation
 124 -Wconversion
 116 -Wdeprecated-non-prototype
  28 -Wmaybe-uninitialized
   4 -Wsometimes-uninitialized
 111 -Wstrict-prototypes
   3 -Wtabs
  10 -Wunused-dummy-argument
   1 -Wunused-label
   2 -Wunused-variable

This also cures the BUS error of t/t9.t and t/t12.t since there's no optimisation (-O2) 🤷

With -Werror to CFLAGS the first error is:

libtool: compile:  gcc -DPACKAGE_NAME=\"pgplot\" -DPACKAGE_TARNAME=\"pgplot\" -DPACKAGE_VERSION=\"5.2.2-9\" "-DPACKAGE_STRING=\"pgplot 5.2.2-9\"" -DPACKAGE_BUGREPORT=\"djerius@cfa.harvard.edu\" -DPACKAGE_URL=\"\" -DPACKAGE=\"pgplot\" -DVERSION=\"5.2.2-9\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DSTDC_HEADERS=1 -DHAVE_FCNTL_H=1 -DHAVE_LIMITS_H=1 -DHAVE_MEMORY_H=1 -DHAVE_NETDB_H=1 -DHAVE_NETINET_IN_H=1 -DHAVE_STDDEF_H=1 -DHAVE_SYS_FILE_H=1 -DHAVE_SYS_SOCKET_H=1 -DHAVE_SYS_TIME_H=1 -DHAVE_UNISTD_H=1 -DHAVE_STDLIB_H=1 -DHAVE_MALLOC=1 -DHAVE_STDLIB_H=1 -DHAVE_REALLOC=1 -DHAVE_GETHOSTBYNAME=1 -DHAVE_GETHOSTNAME=1 -DHAVE_MEMSET=1 -DHAVE_SELECT=1 -DHAVE_SOCKET=1 -DHAVE_SQRT=1 -DHAVE_STRRCHR=1 -DHAVE_STRTOL=1 -DSIZEOF_VOID_P=8 -I. -I/usr/X11/include -I/usr/X11/include -I/opt/local/include/libpng16 -I/opt/local/include -DPG_PPU -g -Wall -Wpedantic -Werror -MT grdate.lo -MD -MP -MF .deps/grdate.Tpo -c grdate.c  -fno-common -DPIC -o grdate.o
grdate.c:30:6: error: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype]
   30 | void GRDATE(string, slen, maxlen)
      |      ^
grdate.c:5:16: note: expanded from macro 'GRDATE'
    5 | #define GRDATE grdate_
      |                ^
1 error generated.
make[2]: *** [grdate.lo] Error 1
make[1]: *** [all-recursive] Error 1

Including -Werror in FFLAGS the first error is:

Making all in src
/bin/sh ../libtool  --tag=F77   --mode=compile aarch64-apple-darwin24-gfortran-mp-14 -std=legacy -g -Wall -Wpedantic -Werror -c -o grarea.lo grarea.f
libtool: compile:  aarch64-apple-darwin24-gfortran-mp-14 -std=legacy -g -Wall -Wpedantic -Werror -c grarea.f  -fno-common -o grarea.o
grpckg1.inc:95:7:

   95 |       CHARACTER*11       GRGCAP(GRIMAX)
      |       1
Error: Unclassifiable statement at (1)
make[1]: *** [grarea.lo] Error 1
make: *** [all-recursive] Error 1

[kiwiroy]

djerius/pgplot-autotool@main...kiwiroy:pgplot-autotool:fixes-for-perl5-pgplot resolves both issues when using that version of pgplot under -O2 optimisation

[mohawk2]

I don't think that turning off optimisation is any kind of solution.