[tryout fix] concurrency bug in NamespacedHierarchicalStore#computeIfAbsent(Object, Object, Function) junit-team#5171 junit-team#5209

Signed-off-by: Vincent Potucek <[email protected]>

Author: Vincent Potucek

platform-tests/src/test/java/org/junit/platform/engine/support/store/NamespacedHierarchicalStoreTests.java

@@ -34,7 +34,6 @@
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicBoolean;
-import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.function.Function;
 
@@ -711,7 +710,9 @@ public int hashCode() {
 				// Force all CollidingKey instances to have the same hash code
 				return 42;
 			}
-		}@SuppressWarnings("deprecation")
+		}
+
+		@SuppressWarnings("deprecation")
 		@Test
 		void getOrComputeIfAbsentDoesNotDeadlockWithCollidingKeys() throws Exception {
 			var store = new NamespacedHierarchicalStore<String>(null);
@@ -768,18 +769,18 @@ void getOrComputeIfAbsentDoesNotDeadlockWithCollidingKeys2() throws Exception {
 				var firstThreadTimedOut = new AtomicBoolean(false);
 
 				Thread first = new Thread(
-						() -> localStore.getOrComputeIfAbsent(namespace, new CollidingKey("k1"), __ -> {
-							firstComputationStarted.countDown();
-							try {
-								if (!secondComputationAllowedToFinish.await(200, TimeUnit.MILLISECONDS)) {
-									firstThreadTimedOut.set(true);
-								}
-							}
-							catch (InterruptedException e) {
-								Thread.currentThread().interrupt();
+					() -> localStore.getOrComputeIfAbsent(namespace, new CollidingKey("k1"), __ -> {
+						firstComputationStarted.countDown();
+						try {
+							if (!secondComputationAllowedToFinish.await(200, TimeUnit.MILLISECONDS)) {
+								firstThreadTimedOut.set(true);
 							}
-							return "value1";
-						}));
+						}
+						catch (InterruptedException e) {
+							Thread.currentThread().interrupt();
+						}
+						return "value1";
+					}));
 
 				Thread second = new Thread(() -> {
 					try {
@@ -801,7 +802,7 @@ void getOrComputeIfAbsentDoesNotDeadlockWithCollidingKeys2() throws Exception {
 				second.join(1000);
 
 				assertThat(firstThreadTimedOut).as(
-						"getOrComputeIfAbsent should not block subsequent computations on colliding keys").isFalse();
+					"getOrComputeIfAbsent should not block subsequent computations on colliding keys").isFalse();
 			}
 		}
 
@@ -845,7 +846,7 @@ void computeIfAbsentCanDeadlockWithCollidingKeys() throws Exception {
 				second.join(1000);
 
 				assertThat(firstThreadTimedOut).as(
-						"computeIfAbsent should not block subsequent computations on colliding keys").isFalse();
+					"computeIfAbsent should not block subsequent computations on colliding keys").isFalse();
 			}
 		}