Minor optimizations (#2727)

Author: IhateTrains

ImperatorToCK3.UnitTests/CK3/Characters/CK3CharacterTests.cs

@@ -6,7 +6,6 @@
 using AwesomeAssertions;
 using ImperatorToCK3.CK3;
 using ImperatorToCK3.CK3.Characters;
-using ImperatorToCK3.CK3.Cultures;
 using ImperatorToCK3.CK3.Dynasties;
 using ImperatorToCK3.CK3.Religions;
 using ImperatorToCK3.CK3.Titles;
@@ -28,7 +27,6 @@
 using System.Collections.Generic;
 using System.Linq;
 using Xunit;
-using Culture = ImperatorToCK3.Imperator.Cultures.Culture;
 
 namespace ImperatorToCK3.UnitTests.CK3.Characters;
 
@@ -94,7 +92,7 @@ internal Character Build() {
 				DNAFactory,
 				new Date(867, 1, 1),
 				config,
-				unlocalizedImperatorNames: new HashSet<string>()
+				unlocalizedImperatorNames: []
 			);
 			return character;
 		}

ImperatorToCK3.UnitTests/CK3/Dynasties/DynastyTests.cs

@@ -23,7 +23,6 @@
 using Xunit;
 using Character = ImperatorToCK3.CK3.Characters.Character;
 using System;
-using System.Collections.Generic;
 using CharacterCollection = ImperatorToCK3.Imperator.Characters.CharacterCollection;
 
 // ReSharper disable StringLiteralTypo
@@ -91,7 +90,7 @@ public Character Build() {
 				new DNAFactory(IRModFS, ck3ModFS),
 				new Date(867, 1, 1),
 				config,
-				unlocalizedImperatorNames: new HashSet<string>()
+				unlocalizedImperatorNames: []
 			);
 			return character;
 		}

ImperatorToCK3/CK3/Characters/Character.cs

@@ -374,7 +374,7 @@ internal Character(
 		DNAFactory dnaFactory,
 		Date dateOnConversion,
 		Configuration config,
-		ISet<string> unlocalizedImperatorNames
+		ConcurrentHashSet<string> unlocalizedImperatorNames
 	) {
 		this.characters = characters;
 

ImperatorToCK3/CK3/Characters/CharacterCollection.cs

@@ -103,7 +103,7 @@ private void ImportImperatorCharacter(
 		DNAFactory dnaFactory,
 		Date endDate,
 		Configuration config,
-		ISet<string> unlocalizedImperatorNames) {
+		ConcurrentHashSet<string> unlocalizedImperatorNames) {
 		// Create a new CK3 character.
 		var newCharacter = new Character(
 			irCharacter,

ImperatorToCK3/CK3/Religions/ReligionCollection.cs

@@ -325,8 +325,8 @@ Date date
 	}
 
 	// Returns a dictionary with CK3 provinces that are mapped to Imperator provinces, grouped by faith.
-	public static IDictionary<string, ISet<Province>> GetProvincesFromImperatorByFaith(ProvinceCollection ck3Provinces, Date date) {
-		var provincesByFaith = new Dictionary<string, ISet<Province>>();
+	public static Dictionary<string, HashSet<Province>> GetProvincesFromImperatorByFaith(ProvinceCollection ck3Provinces, Date date) {
+		var provincesByFaith = new Dictionary<string, HashSet<Province>>();
 
 		foreach (var province in ck3Provinces) {
 			var imperatorProvince = province.PrimaryImperatorProvince;
@@ -342,7 +342,7 @@ public static IDictionary<string, ISet<Province>> GetProvincesFromImperatorByFai
 			if (provincesByFaith.TryGetValue(faith, out var set)) {
 				set.Add(province);
 			} else {
-				provincesByFaith[faith] = new HashSet<Province> {province};
+				provincesByFaith[faith] = [province];
 			}
 		}
 
@@ -484,13 +484,13 @@ Date date
 		title.SetHolder(character, date);
 	}
 
-	private List<Title> GetDynamicHolySiteBaroniesForFaith(Faith faith, IDictionary<string, ISet<Province>> provincesByFaith) {
+	private List<Title> GetDynamicHolySiteBaroniesForFaith(Faith faith, Dictionary<string, HashSet<Province>> provincesByFaith) {
 		// Collect all Imperator territories that are mapped to this faith.
-		ISet<Province> faithTerritories;
+		HashSet<Province> faithTerritories;
 		if (provincesByFaith.TryGetValue(faith.Id, out var set)) {
 			faithTerritories = set;
 		} else {
-			faithTerritories = new HashSet<Province>();
+			faithTerritories = [];
 		}
 
 		// Split the territories into 2 sets: territories that have a holy site and territories that do not.

ImperatorToCK3/Imperator/Inventions/InventionsDB.cs

@@ -29,7 +29,7 @@ public void LoadInventions(ModFilesystem irModFS) {
 		inventionGroupsParser.ParseGameFolder("common/inventions", irModFS, "txt", recursive: true);
 	}
 
-	public IEnumerable<string> GetActiveInventionIds(IList<bool> booleans) {
+	public IEnumerable<string> GetActiveInventionIds(List<bool> booleans) {
 		// Enumerate over the inventions and return the ones that are active (bool is true).
 		foreach (var item in inventionIds.Select((inventionId, i) => new { i, inventionId })) {
 			if (item.i < booleans.Count && booleans[item.i]) {

ImperatorToCK3/Mappers/Gene/MorphGeneTemplateMapper.cs

@@ -6,7 +6,7 @@
 namespace ImperatorToCK3.Mappers.Gene;
 
 internal sealed class MorphGeneTemplateMapper {
-	private readonly Dictionary<string, IList<Assignment>> templateMappings = []; // <geneName, <irTemplate, ck3Template>>
+	private readonly Dictionary<string, List<Assignment>> templateMappings = []; // <geneName, <irTemplate, ck3Template>>
 
 	public MorphGeneTemplateMapper(string mappingsFilePath) {
 		var parser = new Parser();

ImperatorToCK3/Mappers/Technology/InnovationMapper.cs

@@ -73,7 +73,7 @@ public void LogUnmappedInventions(InventionsDB inventionsDB, LocDB irLocDB) {
 
 	// TODO: ALSO LOG UNMAPPED CK3 MARTIAL AND CIVIC INNOVATIONS
 
-	public void RemoveMappingsWithInvalidInnovations(ISet<string> innovationIds) {
+	public void RemoveMappingsWithInvalidInnovations(HashSet<string> innovationIds) {
 		int removedCount = 0;
 
 		removedCount += innovationLinks

ImperatorToCK3/Outputter/BookmarkOutputter.cs

@@ -279,7 +279,7 @@ private static FrozenSet<ulong> GetColorableImpassablesExceptMapEdgeProvinces(Ma
 		return mapData.ColorableImpassableProvinceIds.Except(mapData.MapEdgeProvinceIds).ToFrozenSet();
 	}
 
-	private static HashSet<ulong> GetImpassableProvincesToColor(MapData mapData, ISet<ulong> heldProvinceIds) {
+	private static HashSet<ulong> GetImpassableProvincesToColor(MapData mapData, HashSet<ulong> heldProvinceIds) {
 		var provinceIdsToColor = new HashSet<ulong>(heldProvinceIds);
 		var impassableIds = GetColorableImpassablesExceptMapEdgeProvinces(mapData);
 		foreach (ulong impassableId in impassableIds) {