A frontend option to skip holding owners import (#2688) #minor

closes #2563

Author: IhateTrains

ImperatorToCK3/CK3/World.cs

@@ -346,8 +346,12 @@ public World(Imperator.World impWorld, Configuration config, Thread? irCoaExtrac
 
 		// Give counties to rulers and governors.
 		OverwriteCountiesHistory(impWorld.Countries, impWorld.JobsDB.Governorships, countyLevelCountries, countyLevelGovernorships, impWorld.Characters, impWorld.Provinces, CorrectedDate);
-		// Import holding owners as barons and counts.
-		LandedTitles.ImportImperatorHoldings(Provinces, impWorld.Characters, impWorld.EndDate);
+		// Import holding owners as barons and counts (optional).
+		if (!config.SkipHoldingOwnersImport) {
+			LandedTitles.ImportImperatorHoldings(Provinces, impWorld.Characters, impWorld.EndDate);
+		} else {
+			Logger.Info("Skipping holding owners import per configuration.");
+		}
 
 		LandedTitles.ImportDevelopmentFromImperator(Provinces, CorrectedDate, config.ImperatorCivilizationWorth);
 		LandedTitles.RemoveInvalidLandlessTitles(config.CK3BookmarkDate);

ImperatorToCK3/Configuration.cs

@@ -28,6 +28,7 @@ public sealed class Configuration {
 	public LegionConversion LegionConversion { get; set; } = LegionConversion.MenAtArms;
 	public Date CK3BookmarkDate { get; set; } = new(0, 1, 1);
 	public bool SkipDynamicCoAExtraction { get; set; } = false;
+	public bool SkipHoldingOwnersImport { get; set; } = true;
 	public bool FallenEagleEnabled { get; private set; }
 	public bool WhenTheWorldStoppedMakingSenseEnabled { get; private set; }
 	public bool RajasOfAsiaEnabled { get; private set; }
@@ -153,6 +154,15 @@ private void RegisterKeys(Parser parser) {
 				Logger.Error($"Undefined error, {nameof(SkipDynamicCoAExtraction)} value was: {valueString}; Error message: {e}");
 			}
 		});
+		parser.RegisterKeyword("SkipHoldingOwnersImport", reader => {
+			var valueString = reader.GetString();
+			try {
+				SkipHoldingOwnersImport = Convert.ToInt32(valueString, CultureInfo.InvariantCulture) == 1;
+				Logger.Info($"{nameof(SkipHoldingOwnersImport)} set to: {SkipHoldingOwnersImport}");
+			} catch (Exception e) {
+				Logger.Error($"Undefined error, {nameof(SkipHoldingOwnersImport)} value was: {valueString}; Error message: {e}");
+			}
+		});
 		parser.RegisterRegex(CommonRegexes.Catchall, ParserHelpers.IgnoreAndLogItem);
 	}
 

ImperatorToCK3/Data_Files/fronter_configuration/fronter-options.txt

@@ -139,6 +139,26 @@ option = {
 	}
 }
 
+option = {
+	name = SkipHoldingOwnersImport
+	displayName = SKIP_HOLDING_OWNERS_IMPORT
+	tooltip = SKIP_HOLDING_OWNERS_IMPORT_TIP
+	radioSelector = {
+		radioOption = {
+			name = 1
+			displayName = SKIP_HOLDING_OWNERS_IMPORT_1
+			tooltip = SKIP_HOLDING_OWNERS_IMPORT_1_TIP
+			default = true
+		}
+		radioOption = {
+			name = 0
+			displayName = SKIP_HOLDING_OWNERS_IMPORT_0
+			tooltip = SKIP_HOLDING_OWNERS_IMPORT_0_TIP
+			default = false
+		}
+	}
+}
+
 option = {
 	name = output_name
 	displayName = MODNAME

ImperatorToCK3/Data_Files/fronter_configuration/options_l_english.yml

@@ -62,3 +62,10 @@ l_english:
  SKIP_DYNAMIC_COA_EXTRACTION_0_TIP: "The converter will launch Imperator to extract all game-generated flags."
  SKIP_DYNAMIC_COA_EXTRACTION_1: "Yes"
  SKIP_DYNAMIC_COA_EXTRACTION_1_TIP: "The converted will not launch Imperator to extract all game-generated flags."
+
+ SKIP_HOLDING_OWNERS_IMPORT: "Should importing holding owners be skipped?"
+ SKIP_HOLDING_OWNERS_IMPORT_TIP: "Whether the converter should import Imperator holding owners as barons and counts."
+ SKIP_HOLDING_OWNERS_IMPORT_0: "No"
+ SKIP_HOLDING_OWNERS_IMPORT_0_TIP: "The converter will import holding owners as barons and counts."
+ SKIP_HOLDING_OWNERS_IMPORT_1: "Yes"
+ SKIP_HOLDING_OWNERS_IMPORT_1_TIP: "The converter will not import holding owners as barons and counts."

ImperatorToCK3/Data_Files/fronter_configuration/options_l_simp_chinese.yml

@@ -18,3 +18,10 @@ l_simp_chinese:
  MODNAME: "MOD导出名称（可选）："
  MODNAMETIP: "请使用Latin字母"
  MODNAMETIP2: "可选的MOD导出名称（默认名称使用存档名之一）"
+
+ SKIP_HOLDING_OWNERS_IMPORT: "是否跳过导入领地所有者？"
+ SKIP_HOLDING_OWNERS_IMPORT_TIP: "是否将 Imperator 的领地所有者导入为男爵和伯爵。"
+ SKIP_HOLDING_OWNERS_IMPORT_0: "否"
+ SKIP_HOLDING_OWNERS_IMPORT_0_TIP: "转换器会将领地所有者导入为男爵和伯爵。"
+ SKIP_HOLDING_OWNERS_IMPORT_1: "是"
+ SKIP_HOLDING_OWNERS_IMPORT_1_TIP: "转换器不会将领地所有者导入为男爵和伯爵。"