Harden M::B code to be strict compliant in tests and Build.PL generation.

Author: toddr

lib/Module/Build/Base.pm

@@ -1080,7 +1080,7 @@ sub subclass {
   print $fh <<EOF;
 package $opts{class};
 use $pack;
-\@ISA = qw($pack);
+our \@ISA = qw($pack);
 $opts{code}
 1;
 EOF

t/lib/DistGen.pm

@@ -214,14 +214,16 @@ sub _gen_default_filedata {
   } else {
     $self->$add_unless($module_filename, undent(<<"      ---"));
       package $self->{name};
+      use strict;
+      use warnings;
 
-      \$VERSION = $self->{version};
+      our \$VERSION = $self->{version};
 
       require Exporter;
       require DynaLoader;
 
-      \@ISA = qw(Exporter DynaLoader);
-      \@EXPORT_OK = qw( okay );
+      our \@ISA = qw(Exporter DynaLoader);
+      our \@EXPORT_OK = qw( okay );
 
       bootstrap $self->{name} \$VERSION;
 

t/notes.t

@@ -17,9 +17,12 @@ $dist->chdir_in;
 
 ###################################
 $dist->change_file( 'Build.PL', <<"---" );
+use strict;
+use warnings;
 use Module::Build;
+
 my \$build = Module::Build->new(
-  module_name => @{[$dist->name]},
+  module_name => '@{[$dist->name]}',
   license     => 'perl'
 );
 \$build->create_build_script;

t/xs.t

@@ -166,13 +166,16 @@ okay()
 $dist->add_file( 'Simple.pm', <<"---" );
 package Simple;
 
-\$VERSION = '0.01';
+use strict;
+use warnings;
+
+our \$VERSION = '0.01';
 
 require Exporter;
 require DynaLoader;
 
-\@ISA = qw( Exporter DynaLoader );
-\@EXPORT_OK = qw( okay );
+our \@ISA = qw( Exporter DynaLoader );
+our \@EXPORT_OK = qw( okay );
 
 bootstrap Simple \$VERSION;