Skip to content

Commit 7711e90

Browse files
committed
[PC-1413] OnboardingPageProvider 위치 이동하여 가독성 추가
1 parent 4f60d56 commit 7711e90

File tree

3 files changed

+7
-24
lines changed

3 files changed

+7
-24
lines changed

feature/onboarding/src/main/java/com/puzzle/onboarding/model/OnboardingData.kt

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,4 @@ internal val onboardingPages = listOf(
6868
buttonLabelRes = null,
6969
contentType = PageContentType.Image(R.drawable.ic_onboarding_screenshot)
7070
)
71-
)
72-
73-
class OnboardingPageProvider : PreviewParameterProvider<OnboardingPageData> {
74-
override val values: Sequence<OnboardingPageData> = onboardingPages.asSequence()
75-
}
71+
)

feature/onboarding/src/main/java/com/puzzle/onboarding/ui/PageContent.kt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,13 @@ import androidx.compose.ui.res.stringResource
1717
import androidx.compose.ui.text.style.TextAlign
1818
import androidx.compose.ui.tooling.preview.Preview
1919
import androidx.compose.ui.tooling.preview.PreviewParameter
20+
import androidx.compose.ui.tooling.preview.PreviewParameterProvider
2021
import androidx.compose.ui.unit.dp
2122
import com.puzzle.common.ui.PieceGuideMessageAnimation
2223
import com.puzzle.designsystem.foundation.PieceTheme
2324
import com.puzzle.onboarding.model.OnboardingPageData
24-
import com.puzzle.onboarding.model.OnboardingPageProvider
2525
import com.puzzle.onboarding.model.PageContentType
26+
import com.puzzle.onboarding.model.onboardingPages
2627
import com.puzzle.onboarding.ui.components.StopAtProgressLottie
2728

2829
@Composable
@@ -74,6 +75,10 @@ internal fun PageContent(
7475
}
7576
}
7677

78+
class OnboardingPageProvider : PreviewParameterProvider<OnboardingPageData> {
79+
override val values: Sequence<OnboardingPageData> = onboardingPages.asSequence()
80+
}
81+
7782
@Preview
7883
@Composable
7984
private fun PreviewOnboardingAllPages(

feature/onboarding/src/main/java/com/puzzle/onboarding/ui/components/StopAtProgressLottie.kt

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,10 @@ import androidx.compose.runtime.setValue
1212
import androidx.compose.runtime.snapshotFlow
1313
import androidx.compose.ui.Modifier
1414
import androidx.compose.ui.layout.ContentScale
15-
import androidx.compose.ui.tooling.preview.Preview
16-
import androidx.compose.ui.tooling.preview.PreviewParameter
1715
import com.airbnb.lottie.compose.LottieAnimation
1816
import com.airbnb.lottie.compose.LottieCompositionSpec
1917
import com.airbnb.lottie.compose.animateLottieCompositionAsState
2018
import com.airbnb.lottie.compose.rememberLottieComposition
21-
import com.puzzle.designsystem.foundation.PieceTheme
22-
import com.puzzle.onboarding.model.OnboardingPageData
23-
import com.puzzle.onboarding.model.OnboardingPageProvider
2419

2520
@Composable
2621
internal fun StopAtProgressLottie(
@@ -69,17 +64,4 @@ internal fun StopAtProgressLottie(
6964
contentScale = ContentScale.FillWidth,
7065
modifier = modifier
7166
)
72-
}
73-
74-
@Preview
75-
@Composable
76-
private fun PreviewStopAtProgressLottie(
77-
@PreviewParameter(OnboardingPageProvider::class) pageData: OnboardingPageData
78-
) {
79-
PieceTheme {
80-
StopAtProgressLottie(
81-
lottieRes = pageData.titleRes,
82-
shouldPlay = true
83-
)
84-
}
8567
}

0 commit comments

Comments
 (0)