Skip to content

Commit 6439495

Browse files
authored
Merge pull request #212 from jecisc/deprecate-normalizer
Deprecate normalizer
2 parents 4be99a0 + 8116241 commit 6439495

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

src/DataFrame/DataFrame.class.st

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -159,12 +159,6 @@ Class {
159159
#category : #'DataFrame-Core'
160160
}
161161

162-
{ #category : #defaults }
163-
DataFrame class >> defaultNormalizer [
164-
165-
^ AIMinMaxNormalizer
166-
]
167-
168162
{ #category : #'instance creation' }
169163
DataFrame class >> new: aPoint [
170164

@@ -1366,11 +1360,11 @@ DataFrame >> normalized [
13661360
"This methods returns a new DataFrame, without altering this one, that has all the columns normalized."
13671361

13681362
| normalizers normalizedColumns |
1369-
normalizers := (1 to: self anyOne size) collect: [ :e | self class defaultNormalizer new ].
1363+
self deprecated:
1364+
'DataFrame will remove the dependency over normalization in the next version. You can use pharo-ai/data-preprocessing project to normalize your DataFrame and even more!'.
1365+
normalizers := (1 to: self anyOne size) collect: [ :e | self class defaultNormalizerClass new ].
13701366

1371-
normalizedColumns := self columns
1372-
with: normalizers
1373-
collect: [ :col :normalizer | col normalizedUsing: normalizer ].
1367+
normalizedColumns := self columns with: normalizers collect: [ :col :normalizer | col normalizedUsing: normalizer ].
13741368

13751369
^ self class withColumns: normalizedColumns columnNames: self columnNames
13761370
]

0 commit comments

Comments
 (0)