Merge pull request #116 from PrefectHQ/useStorage-shim-existing-keys

stackoverfloweth · web-flow · commit d6266b16673c · 2022-10-25T14:20:59.000-05:00
BugFix: useStorage better support transferring old storage values
diff --git a/src/useStorage/storage.ts b/src/useStorage/storage.ts
@@ -34,7 +34,12 @@ export class StorageManager {
       return defaultValue
     }
 
-    return JSON.parse(value) as T
+    try {
+      return JSON.parse(value) as T
+    } catch {
+      console.error(`Unable to parse current value for key ${key}, returning default instead`)
+      return defaultValue
+    }
   }
 
   public set<T>(key: string, value: T): void {

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,12 @@ export class StorageManager {`
`34`	`34`	`return defaultValue`
`35`	`35`	`}`
`36`	`36`
`37`		`- return JSON.parse(value) as T`
	`37`	`+ try {`
	`38`	`+ return JSON.parse(value) as T`
	`39`	`+ } catch {`
	`40`	+ console.error(`Unable to parse current value for key ${key}, returning default instead`)
	`41`	`+ return defaultValue`
	`42`	`+ }`
`38`	`43`	`}`
`39`	`44`
`40`	`45`	`public set<T>(key: string, value: T): void {`