fix: Overall type-hinting improvements #2457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YoggieS <[email protected]>
Co-authored-by: plun1331 <[email protected]> Signed-off-by: YoggieS <[email protected]>
Contributor
Author
|
I think I caught most of what was wrong, this PR overwrites #2456 at the same time because I transferred the changes to this branch (so if it's ok then that one can be closed). |
9 tasks
plun1331
added
bug
Contributor
Author
|
@plun1331 by now it should be all there, you can look at it at your free time |
yoggys
commented
May 18, 2024
plun1331
reviewed
May 18, 2024
NeloBlivion
requested changes
May 18, 2024
plun1331
previously approved these changes
May 28, 2024
Member
plun1331
left a comment
plun1331
left a comment
There was a problem hiding this comment.
I trust that you've double checked that these are all correct
Dorukyum
requested changes
May 29, 2024
Dorukyum
requested changes
May 29, 2024
Co-authored-by: Dorukyum <[email protected]> Signed-off-by: YoggieS <[email protected]>
Dorukyum
approved these changes
May 29, 2024
baribarton
pushed a commit
to baribarton/pycord-no-potential-reconnect
that referenced
this pull request
Oct 24, 2024
* fix: RawMemberRemoveEvent type-hinting * Update CHANGELOG.md Signed-off-by: YoggieS <[email protected]> * style(pre-commit): auto fixes from pre-commit.com hooks * Update CHANGELOG.md Co-authored-by: plun1331 <[email protected]> Signed-off-by: YoggieS <[email protected]> * fix: overall type-hinting * style(pre-commit): auto fixes from pre-commit.com hooks * fix: further types lookup & fixes * style(pre-commit): auto fixes from pre-commit.com hooks * Update discord/guild.py Co-authored-by: UK <[email protected]> Signed-off-by: YoggieS <[email protected]> * review suggestions * review suggestions v2 * style(pre-commit): auto fixes from pre-commit.com hooks * review suggestions v3 * update changelog with correct # * nonce typing partial revert * onboarding PromptOption types * Update CHANGELOG.md Co-authored-by: Dorukyum <[email protected]> Signed-off-by: YoggieS <[email protected]> --------- Signed-off-by: YoggieS <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: plun1331 <[email protected]> Co-authored-by: UK <[email protected]> Co-authored-by: Dorukyum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Overall code type-hinting improvements.
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.