chore: clear preload links when completed

Author: wmertens

packages/qwik/src/core/qrl/preload.ts

@@ -103,7 +103,6 @@ export const loadBundleGraph = (element: Element) => {
 
 // we stringify this in prefetch-implementation.ts
 export const makeMakePreloadLink =
-  /*@__PURE__*/
   (canModulePreload: boolean | null) => (url: string, priority: boolean) => {
     const link = document.createElement('link');
     if (canModulePreload === null) {
@@ -119,16 +118,16 @@ export const makeMakePreloadLink =
     if (!canModulePreload) {
       link.as = 'script';
     }
+    link.onload = link.onerror = () => link.remove();
+
     document.head.appendChild(link);
   };
-const makePreloadLink = makeMakePreloadLink(null);
+const makePreloadLink = /*@__PURE__*/ makeMakePreloadLink(null);
 
 const prioritizeLink = (url: string) => {
   const link = document.querySelector(`link[href="${url}"]`) as HTMLLinkElement | null;
   if (link) {
     link.fetchPriority = 'high';
-  } else {
-    console.warn(`Preload link ${url} not found`);
   }
 };
 

starters/e2e/e2e.containers.spec.ts

@@ -42,15 +42,6 @@ test.describe("container", () => {
     const hash = await container.getAttribute("q:manifest-hash");
     const bundleLink = page.locator(`link#qwik-bg-${hash}`).first();
     await expect(bundleLink).toHaveAttribute("href");
-
-    const headPreload = page.locator(`head > link[rel="modulepreload"]`);
-    const beforeCount = await headPreload.count();
-
-    const anchor = container.locator("a");
-    await anchor.click();
-    await expect(anchor).toHaveText("2 / 3");
-
-    const afterCount = await headPreload.count();
-    expect(afterCount).toBeGreaterThan(beforeCount);
+    // We don't have a way to check if other modules are preloaded, because the link goes away
   });
 });