fix: change implementation to vNode field on element

Author: Varixo

packages/qwik/src/core/client/vnode-diff.ts

@@ -741,11 +741,13 @@ export const vnode_diff = (
     }
     const vNode = (vNewNode || vCurrent) as ElementVNode;
 
+    const element = vNode[ElementVNodeProps.element] as QElement;
+    element.vNode = new WeakRef(vNode);
+
     needsQDispatchEventPatch =
       setBulkProps(vNode, jsxAttrs, currentFile) || needsQDispatchEventPatch;
     if (needsQDispatchEventPatch) {
       // Event handler needs to be patched onto the element.
-      const element = vNode[ElementVNodeProps.element] as QElement;
       if (!element.qDispatchEvent) {
         element.qDispatchEvent = (event: Event, scope: QwikLoaderEventScope) => {
           const eventName = event.type;

packages/qwik/src/core/client/vnode.ts

@@ -121,7 +121,13 @@ import { isDev } from '@qwik.dev/core/build';
 import { qwikDebugToString } from '../debug';
 import { assertDefined, assertEqual, assertFalse, assertTrue } from '../shared/error/assert';
 import { QError, qError } from '../shared/error/error';
-import { DEBUG_TYPE, QContainerValue, VirtualType, VirtualTypeName } from '../shared/types';
+import {
+  DEBUG_TYPE,
+  QContainerValue,
+  VirtualType,
+  VirtualTypeName,
+  type QElement,
+} from '../shared/types';
 import { isText } from '../shared/utils/element';
 import {
   dangerouslySetInnerHTML,
@@ -210,6 +216,7 @@ export const vnode_newElement = (element: Element, elementName: string): Element
   assertTrue(vnode_isElementVNode(vnode), 'Incorrect format of ElementVNode.');
   assertFalse(vnode_isTextVNode(vnode), 'Incorrect format of ElementVNode.');
   assertFalse(vnode_isVirtualVNode(vnode), 'Incorrect format of ElementVNode.');
+  (element as QElement).vNode = new WeakRef(vnode);
   return vnode;
 };
 
@@ -228,6 +235,7 @@ export const vnode_newUnMaterializedElement = (element: Element): ElementVNode =
   assertTrue(vnode_isElementVNode(vnode), 'Incorrect format of ElementVNode.');
   assertFalse(vnode_isTextVNode(vnode), 'Incorrect format of ElementVNode.');
   assertFalse(vnode_isVirtualVNode(vnode), 'Incorrect format of ElementVNode.');
+  (element as QElement).vNode = new WeakRef(vnode);
   return vnode;
 };
 
@@ -670,6 +678,11 @@ export const vnode_locate = (rootVNode: ElementVNode, id: string | Element): VNo
     refElement = qVNodeRefs.get(elementOffset)!;
   } else {
     refElement = id;
+
+    const vNode = (refElement as QElement).vNode?.deref();
+    if (vNode) {
+      return vNode;
+    }
   }
   assertDefined(refElement, 'Missing refElement.');
   if (!vnode_isVNode(refElement)) {

packages/qwik/src/core/shared/types.ts

@@ -56,6 +56,7 @@ export type HostElement = VNode | ISsrNode;
 
 export interface QElement extends HTMLElement {
   qDispatchEvent?: (event: Event, scope: QwikLoaderEventScope) => boolean;
+  vNode?: WeakRef<VNode>;
 }
 
 export type qWindow = Window & {

packages/qwik/src/core/use/use-core.ts

@@ -146,12 +146,7 @@ export function invokeApply<FN extends (...args: any) => any>(
 
 export const newInvokeContextFromTuple = ([element, event, url]: InvokeTuple) => {
   const domContainer = getDomContainer(element);
-  let hostElement: HostElement | undefined = undefined;
-  try {
-    hostElement = vnode_locate(domContainer.rootVNode, element);
-  } catch (_) {
-    // ignore
-  }
+  const hostElement = vnode_locate(domContainer.rootVNode, element);
   const locale = domContainer.$locale$;
   locale && setLocale(locale);
   return newInvokeContext(locale, hostElement, element, event, url);