fix: esbuild doesnt allow property mutation on options

Author: thejackshelton

packages/docs/src/routes/api/qwik-optimizer/api.json

@@ -479,24 +479,10 @@
         }
       ],
       "kind": "TypeAlias",
-      "content": "```typescript\nexport type QwikEsbuildPlugin = Plugin & {\n    api: QwikEsbuildPluginApi;\n};\n```\n**References:** [QwikEsbuildPluginApi](#qwikesbuildpluginapi)",
+      "content": "```typescript\nexport type QwikEsbuildPlugin = Plugin;\n```",
       "editUrl": "https://github.com/QwikDev/qwik/tree/main/packages/qwik/src/optimizer/src/plugins/esbuild.ts",
       "mdFile": "qwik.qwikesbuildplugin.md"
     },
-    {
-      "name": "QwikEsbuildPluginApi",
-      "id": "qwikesbuildpluginapi",
-      "hierarchy": [
-        {
-          "name": "QwikEsbuildPluginApi",
-          "id": "qwikesbuildpluginapi"
-        }
-      ],
-      "kind": "TypeAlias",
-      "content": "```typescript\nexport type QwikEsbuildPluginApi = {\n    getOptimizer: () => Optimizer;\n    getOptions: () => NormalizedQwikPluginOptions;\n};\n```\n**References:** [Optimizer](#optimizer)",
-      "editUrl": "https://github.com/QwikDev/qwik/tree/main/packages/qwik/src/optimizer/src/plugins/esbuild.ts",
-      "mdFile": "qwik.qwikesbuildpluginapi.md"
-    },
     {
       "name": "QwikEsbuildPluginOptions",
       "id": "qwikesbuildpluginoptions",

packages/docs/src/routes/api/qwik-optimizer/index.mdx

@@ -1492,26 +1492,9 @@ Plugin
 ## QwikEsbuildPlugin
 
 ```typescript
-export type QwikEsbuildPlugin = Plugin & {
-  api: QwikEsbuildPluginApi;
-};
-```
-
-**References:** [QwikEsbuildPluginApi](#qwikesbuildpluginapi)
-
-[Edit this section](https://github.com/QwikDev/qwik/tree/main/packages/qwik/src/optimizer/src/plugins/esbuild.ts)
-
-## QwikEsbuildPluginApi
-
-```typescript
-export type QwikEsbuildPluginApi = {
-  getOptimizer: () => Optimizer;
-  getOptions: () => NormalizedQwikPluginOptions;
-};
+export type QwikEsbuildPlugin = Plugin;
 ```
 
-**References:** [Optimizer](#optimizer)
-
 [Edit this section](https://github.com/QwikDev/qwik/tree/main/packages/qwik/src/optimizer/src/plugins/esbuild.ts)
 
 ## QwikEsbuildPluginOptions

packages/qwik/src/optimizer/src/index.ts

@@ -42,11 +42,7 @@ export type {
 
 export type { ExperimentalFeatures, QwikBuildMode, QwikBuildTarget } from './plugins/plugin';
 export type { QwikRollupPluginOptions } from './plugins/rollup';
-export type {
-  QwikEsbuildPluginOptions,
-  QwikEsbuildPlugin,
-  QwikEsbuildPluginApi,
-} from './plugins/esbuild';
+export type { QwikEsbuildPluginOptions, QwikEsbuildPlugin } from './plugins/esbuild';
 export type {
   QwikViteDevResponse,
   QwikVitePlugin,

packages/qwik/src/optimizer/src/plugins/esbuild.ts

@@ -1,7 +1,6 @@
 import type { Plugin, PluginBuild } from 'esbuild';
 import type {
   EntryStrategy,
-  Optimizer,
   OptimizerOptions,
   QwikManifest,
   TransformModule,
@@ -10,18 +9,11 @@ import type {
 import {
   createQwikPlugin,
   type ExperimentalFeatures,
-  type NormalizedQwikPluginOptions,
   type QwikBuildMode,
   type QwikBuildTarget,
   type QwikPluginOptions,
 } from './plugin';
 
-/** @public */
-export type QwikEsbuildPluginApi = {
-  getOptimizer: () => Optimizer;
-  getOptions: () => NormalizedQwikPluginOptions;
-};
-
 /** @public */
 export function qwikEsbuild(qwikEsbuildOpts: QwikEsbuildPluginOptions = {}): Plugin {
   const qwikPlugin = createQwikPlugin(qwikEsbuildOpts.optimizerOptions);
@@ -205,12 +197,6 @@ export function qwikEsbuild(qwikEsbuildOpts: QwikEsbuildPluginOptions = {}): Plu
     },
   };
 
-  // Add API methods to the plugin
-  (esbuildPlugin as any).api = {
-    getOptimizer: () => qwikPlugin.getOptimizer(),
-    getOptions: () => qwikPlugin.getOptions(),
-  };
-
   return esbuildPlugin;
 }
 
@@ -363,4 +349,4 @@ export interface QwikEsbuildPluginOptions {
 export { ExperimentalFeatures } from './plugin';
 
 /** @public */
-export type QwikEsbuildPlugin = Plugin & { api: QwikEsbuildPluginApi };
+export type QwikEsbuildPlugin = Plugin;

packages/qwik/src/optimizer/src/plugins/esbuild.unit.ts

@@ -27,37 +27,17 @@ test('esbuild plugin creation', async () => {
 
   assert.equal(plugin.name, 'esbuild-plugin-qwik');
   assert.equal(typeof plugin.setup, 'function');
-  assert.equal(typeof (plugin as any).api, 'object');
-});
-
-test('esbuild plugin api methods', async () => {
-  const initOpts: QwikEsbuildPluginOptions = {
-    optimizerOptions: mockOptimizerOptions(),
-  };
-  const plugin = qwikEsbuild(initOpts);
-  const api = (plugin as any).api;
-
-  assert.equal(typeof api.getOptimizer, 'function');
-  assert.equal(typeof api.getOptions, 'function');
 });
 
 test('esbuild default options, client', async () => {
   const initOpts: QwikEsbuildPluginOptions = {
     optimizerOptions: mockOptimizerOptions(),
   };
   const plugin = qwikEsbuild(initOpts);
-  const api = (plugin as any).api;
-
-  // The plugin needs to be initialized to get options
-  // In a real scenario, this would happen during the setup phase
-  try {
-    const options = api.getOptions();
-    // Options won't be available until the plugin is initialized
-    assert.equal(options.target, 'client');
-  } catch (error) {
-    // Expected since plugin isn't initialized yet
-    assert.equal((error as Error).message, 'Qwik plugin has not been initialized');
-  }
+
+  // Plugin should be created successfully with default options
+  assert.equal(plugin.name, 'esbuild-plugin-qwik');
+  assert.equal(typeof plugin.setup, 'function');
 });
 
 test('esbuild options, ssr target', async () => {
@@ -212,8 +192,6 @@ describe('esbuild plugin integration', () => {
     assert.equal(plugin.name, 'esbuild-plugin-qwik');
 
     // The plugin should be created successfully with all options
-    const api = (plugin as any).api;
-    assert.equal(typeof api.getOptimizer, 'function');
-    assert.equal(typeof api.getOptions, 'function');
+    assert.equal(typeof plugin.setup, 'function');
   });
 });

packages/qwik/src/optimizer/src/qwik-binding-map.ts

@@ -30,5 +30,15 @@ export const QWIK_BINDING_MAP = {
         "platformArchABI": "qwik.win32-x64-msvc.node"
       }
     ]
+  },
+  "linux": {
+    "x64": [
+      {
+        "platform": "linux",
+        "arch": "x64",
+        "abi": "gnu",
+        "platformArchABI": "qwik.linux-x64-gnu.node"
+      }
+    ]
   }
 };

packages/qwik/src/optimizer/src/qwik.optimizer.api.md

@@ -191,15 +191,7 @@ export type QwikBundleGraph = Array<string | number>;
 export function qwikEsbuild(qwikEsbuildOpts?: QwikEsbuildPluginOptions): Plugin_2;
 
 // @public (undocumented)
-export type QwikEsbuildPlugin = Plugin_2 & {
-    api: QwikEsbuildPluginApi;
-};
-
-// @public (undocumented)
-export type QwikEsbuildPluginApi = {
-    getOptimizer: () => Optimizer;
-    getOptions: () => NormalizedQwikPluginOptions;
-};
+export type QwikEsbuildPlugin = Plugin_2;
 
 // @public (undocumented)
 export interface QwikEsbuildPluginOptions {
@@ -338,6 +330,8 @@ export interface QwikVitePluginApi {
     getManifest: () => QwikManifest | null;
     // (undocumented)
     getOptimizer: () => Optimizer | null;
+    // Warning: (ae-forgotten-export) The symbol "NormalizedQwikPluginOptions" needs to be exported by the entry point index.d.ts
+    //
     // (undocumented)
     getOptions: () => NormalizedQwikPluginOptions;
     // (undocumented)
@@ -550,10 +544,6 @@ export const versions: {
     qwik: string;
 };
 
-// Warnings were encountered during analysis:
-//
-// /Users/jackshelton/dev/open-source/qwik/dist-dev/dts-out/packages/qwik/src/optimizer/src/plugins/esbuild.d.ts:7:5 - (ae-forgotten-export) The symbol "NormalizedQwikPluginOptions" needs to be exported by the entry point index.d.ts
-
 // (No @packageDocumentation comment for this package)
 
 ```