Skip to content

Commit bddcf90

Browse files
committed
perf: patch rollup for correct bundle generation
temporary until PR gets merged
1 parent 115cee1 commit bddcf90

File tree

4 files changed

+588
-160
lines changed

4 files changed

+588
-160
lines changed

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@
160160
"prettier-plugin-jsdoc": "1.3.0",
161161
"pretty-quick": "4.0.0",
162162
"prompts": "2.4.2",
163-
"rollup": "4.19.0",
163+
"rollup": "4.37.0",
164164
"semver": "7.6.3",
165165
"simple-git-hooks": "2.11.1",
166166
"snoop": "1.0.4",
@@ -197,7 +197,8 @@
197197
"@supabase/realtime-js": "2.8.4"
198198
},
199199
"patchedDependencies": {
200-
200+
201+
201202
}
202203
},
203204
"private": true,

packages/qwik/src/optimizer/src/plugins/plugin.ts

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -893,17 +893,14 @@ export const manifest = ${JSON.stringify(manifest)};\n`;
893893
if (id.endsWith(QWIK_PRELOADER_REAL_ID)) {
894894
return 'qwik-preloader';
895895
}
896-
// TODO when manual chunks fix lands in rollup, remove this guard
897-
if ((opts.entryStrategy as SmartEntryStrategy).manual) {
898-
const module = getModuleInfo(id)!;
899-
const segment = module.meta.segment as SegmentAnalysis | undefined;
900-
901-
if (segment) {
902-
const { hash } = segment;
903-
const chunkName = (opts.entryStrategy as SmartEntryStrategy).manual![hash] || segment.entry;
904-
if (chunkName) {
905-
return chunkName;
906-
}
896+
const module = getModuleInfo(id)!;
897+
const segment = module.meta.segment as SegmentAnalysis | undefined;
898+
899+
if (segment) {
900+
const { hash } = segment;
901+
const chunkName = (opts.entryStrategy as SmartEntryStrategy).manual?.[hash] || segment.entry;
902+
if (chunkName) {
903+
return chunkName;
907904
}
908905
}
909906
return null;

0 commit comments

Comments
 (0)