fix: unmount react root alongside with qwik

[sashkashishka]

Close #7542

What is it?

Bug

Description

There is a bug, while navigating using SPA like approach, the qwikified react components don't call unmount callbacks specified in useEffects hooks.

There is an open issue that mentions such a problem #7542

In this PR the issue is fixed by calling unmount method in react root entity when the qwik wrapper unmounts.

I haven't added unit tests because I haven't found them. If they are needed, please let me know where to write them.

Checklist

• My code follows the developer guidelines of this project
• I performed a self-review of my own code
• I added a changeset with pnpm change
• I made corresponding changes to the Qwik docs
• I added new tests to cover the fix / functionality

[changeset-bot]

🦋 Changeset detected

Latest commit: 76b0aa2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@builder.io/qwik	Patch
eslint-plugin-qwik	Patch
@builder.io/qwik-city	Patch
create-qwik	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[gioboa]

Thanks for your help @sashkashishka
Yep, it will be amazing to cover this part with tests

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7864

npm i https://pkg.pr.new/@builder.io/qwik-city@7864

npm i https://pkg.pr.new/eslint-plugin-qwik@7864

npm i https://pkg.pr.new/create-qwik@7864

commit: e570d5c

[github-actions]

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name	Status	Preview	Last Commit
qwik-docs	✅ Ready (View Log)	Visit Preview	07c5fe0

[sashkashishka]

@gioboa, sure, I'll make it

[gioboa]

I tested the solution with the provided reproduction repo, and it's working fine.

Thanks so much for your help @sashkashishka 💪

[wmertens]

[wmertens]

I would love some tests, but you can add them in a separate PR @sashkashishka.

[sashkashishka]

@gioboa, @wmertens, thank you all for approving!
Sorry for hesitating with tests. I can add them within 2 weeks