Support for per-target Fortran modules #1737
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meinersbur
requested review from
carlobertolli,
estewart08,
gregrodgers,
ronlieb and
zGoldthorpe
as code owners
ronlieb
reviewed
Dec 2, 2025
Contributor
ronlieb
left a comment
ronlieb
left a comment
There was a problem hiding this comment.
hi michael. a local build succeeded ???
Author
|
Local build using |
Author
|
I have 20 test with this seems unrelated |
Meinersbur
requested review from
DominikAdamski
and removed request for
ronlieb
ronlieb
approved these changes
Dec 2, 2025
carlobertolli
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt the aomp build to llvm/llvm-project#169638 / ROCm/llvm-project#679
The upstream change requires the Flang module files to be built per-target by flang-rt, including for amdgcn-amd-amdhsa. This change adds 'flang-rt' to the LLVM_ENABLE_RUNTIMES for amdgcn-amd-amdhsa to build the modules. The already present runtime 'openmp' will build omp_lib.mod for amdgcn-amd-amdhsa.
This PR does not change
build_openmp.sh: Building the .mod files needs to be done only once. The script setsLIBOMP_FORTRAN_MODULES_COMPILERwhich is the old mechanism to build omp_lib.h. It will just do nothing and can be cleaned up later.