Improve on filtering

Author: justinrosner

mlir/test/common_utils/common.py

@@ -11,15 +11,18 @@ def get_arch_features(arch: str):
     arch_features = None
     support_mfma = False
     support_wmma = False
+    support_accel_fp8 = False
     major = chip_name[:-2]
     minor = chip_name[-2:]
     if major == 'gfx9':
         if minor in ['08', '0a']:
             arch_features = 'mfma|dot|atomic_add|atomic_add_f16'
         elif minor == '42':
             arch_features = 'mfma|dot|atomic_add|atomic_add_f16|direct_to_lds_32b'
+            support_accel_fp8 = True
         elif minor == '50':
             arch_features = 'mfma|dot|atomic_add|atomic_add_f16|atomic_add_bf16|direct_to_lds_32b|direct_to_lds_128b|lds_transpose_load'
+            support_accel_fp8 = True
         elif minor == '06':
             arch_features = 'dot'
         else:
@@ -35,13 +38,14 @@ def get_arch_features(arch: str):
         arch_features = 'dot|atomic_add|atomic_fmax_f32|wmma'
     elif major == 'gfx12':
         arch_features = 'dot|atomic_add|atomic_add_f16|atomic_add_bf16|atomic_fmax_f32|wmma'
+        support_accel_fp8 = True
     if arch_features and 'mfma' in arch_features:
         support_mfma = True
         pass
     elif arch_features and 'wmma' in arch_features:
         support_wmma = True
         pass
-    return arch_features, support_mfma, support_wmma
+    return arch_features, support_mfma, support_wmma, support_accel_fp8
 
 
 def hip_check(call_result):

mlir/test/e2e/GemmVariantsNonPowerOfTwoTileSizeFp8.cfg

@@ -1,6 +1,6 @@
 if not (config.arch_support_mfma or config.arch_support_wmma):
   config.unsupported = True
 
-if ("gfx11" in config.arch):
+if not config.arch_support_accel_fp8:
   config.unsupported = True
 

mlir/test/e2e/lit.site.cfg.py.in

@@ -47,12 +47,13 @@ config.arch = ""
 config.features = None
 config.arch_support_mfma = False
 config.arch_support_wmma = False
+config.arch_support_accel_fp8 = False
 if config.rocm_path:
     try:
         agents = get_agents()
         config.arch = ','.join(agents)
         for x in agents:
-            config.features, config.arch_support_mfma, config.arch_support_wmma = get_arch_features(x)
+            config.features, config.arch_support_mfma, config.arch_support_wmma, config.arch_support_accel_fp8 = get_arch_features(x)
             config.substitutions.append(('%features', config.features))
 
         # Check other features here

mlir/test/lit.site.cfg.py.in

@@ -77,14 +77,15 @@ config.no_AMD_GPU = False
 config.arch = ""
 config.arch_support_mfma = False
 config.arch_support_wmma = False
+config.arch_support_accel_fp8 = False
 config.features = None
 if config.rocm_path:
     try:
         agents = get_agents()
         config.arch = ','.join(agents)
         for x in agents:
             if not config.features:
-                config.features, config.arch_support_mfma, config.arch_support_wmma = get_arch_features(x)
+                config.features, config.arch_support_mfma, config.arch_support_wmma, config.arch_support_accel_fp8 = get_arch_features(x)
                 config.substitutions.append(('%features', config.features))
         if not config.arch:
             config.no_AMD_GPU = True