feat: Simplify workspace navigation flow (#126)

Fixes part of #101
Fixes #89

This change removes the need for using enter and escape to enable keyboard navigation when the workspace is focused.

Instead, simply focusing the workspace is sufficient to allow keyboard navigation. Note that this PR goes back to the previous behavior of always enabling keyboard navigation on page load and instead limits the preconditions of navigation keys to check focus rather than feature enabled state. This allows for #89 to be fully mitigated. Since keyboard navigation is never disabled, the cursor position is never lost (and thus doesn't need to be cached). The removal of enter/escape fixes the first part of #101.

This PR also performs some other minor cleanup work in ``navigation_controller.ts``.

Author: BenHenning

src/constants.ts

@@ -28,7 +28,7 @@ export enum SHORTCUT_NAMES {
   IN = 'in',
   OUT = 'out',
   INSERT = 'insert',
-  ENTER_OR_MARK = 'enter_or_mark',
+  MARK = 'mark',
   DISCONNECT = 'disconnect',
   TOOLBOX = 'toolbox',
   EXIT = 'exit',
@@ -51,7 +51,6 @@ export enum SHORTCUT_NAMES {
   CONTEXT_OUT = 'context_out',
   CONTEXT_IN = 'context_in',
   CLEAN_UP = 'clean_up_workspace',
-  INTERCEPT_TAB = 'intercept_tab_navigation',
 }
 
 /**

src/index.ts

@@ -25,8 +25,7 @@ export class KeyboardNavigation {
     const navigationController = new NavigationController();
     navigationController.init();
     navigationController.addWorkspace(workspace);
-    // Turns on keyboard navigation.
-    navigationController.setHasAutoNavigationEnabled(true);
+    navigationController.enable(workspace);
     navigationController.listShortcuts();
 
     this.setGlowTheme();