chore: fix review feedback

Author: rachel-fenichel

src/actions/enter.ts

@@ -128,6 +128,7 @@ export class EnterAction {
    */
   private insertFromFlyout(workspace: WorkspaceSvg) {
     workspace.setResizesEnabled(false);
+    // Create a new event group or append to the existing group.
     const existingGroup = Events.getGroup();
     if (!existingGroup) {
       Events.setGroup(true);

src/actions/move.ts

@@ -199,7 +199,7 @@ export class MoveActions {
     const curNode = workspace?.getCursor()?.getCurNode();
     let block = curNode?.getSourceBlock();
     if (!block) return undefined;
-    while (block && block.isShadow()) {
+    while (block?.isShadow()) {
       block = block.getParent();
       if (!block) {
         throw new Error(

src/actions/mover.ts

@@ -206,7 +206,7 @@ export class Mover {
       info.startLocation,
     );
 
-    if (target) {
+    if (dragStrategy.isNewBlock && target) {
       const newNode = ASTNode.createConnectionNode(target);
       if (newNode) workspace.getCursor()?.setCurNode(newNode);
     }

src/keyboard_drag_strategy.ts

@@ -5,7 +5,6 @@
  */
 
 import {
-  common,
   ASTNode,
   BlockSvg,
   ConnectionType,
@@ -52,8 +51,6 @@ export class KeyboardDragStrategy extends dragging.BlockDragStrategy {
 
   override startDrag(e?: PointerEvent) {
     if (!this.cursor) throw new Error('precondition failure');
-    // Select and focus block.
-    common.setSelected(this.block);
     this.cursor.setCurNode(ASTNode.createBlockNode(this.block));
     super.startDrag(e);
     // Set position of the dragging block, so that it doesn't pop
@@ -166,8 +163,6 @@ export class KeyboardDragStrategy extends dragging.BlockDragStrategy {
     draggingBlock: BlockSvg,
     localConns: RenderedConnection[],
   ): ConnectionCandidate | null {
-    // TODO: Handle the case where the cursor is null, or never return null
-    // from workspace.getCursor()
     if (!this.cursor) throw new Error('precondition failure');
 
     // Helper function for traversal.

src/navigation.ts

@@ -770,8 +770,7 @@ export class Navigation {
    *
    * @param stationaryNode The first node to connect.
    * @param movingBlock The block we're moving.
-   * @returns True if the key was handled; false if something went
-   *     wrong.
+   * @returns True if the connection was successful, false otherwise.
    */
   tryToConnectBlock(
     stationaryNode: Blockly.ASTNode,
@@ -784,6 +783,7 @@ export class Navigation {
     if (!destConnection) return false;
     return this.insertBlock(movingBlock, destConnection);
   }
+
   /**
    * Disconnects the block from its parent and moves it to the position of the
    * workspace node.