refactor: Move the shortcut listing action into the shortcut dialog. (#307)

Author: gonfunko

src/navigation_controller.ts

@@ -557,16 +557,6 @@ export class NavigationController {
       allowCollision: true,
     },
 
-    /** List all of the currently registered shortcuts. */
-    announceShortcuts: {
-      name: Constants.SHORTCUT_NAMES.LIST_SHORTCUTS,
-      callback: () => {
-        this.shortcutDialog.toggle();
-        return true;
-      },
-      keyCodes: [KeyCodes.SLASH],
-    },
-
     /** Announce the current location of the cursor. */
     announceLocation: {
       name: Constants.SHORTCUT_NAMES.ANNOUNCE,
@@ -715,8 +705,9 @@ export class NavigationController {
     this.workspaceMovement.install();
 
     this.clipboard.install();
+    this.shortcutDialog.install();
 
-    // Initalise the shortcut modal with available shortcuts.  Needs
+    // Initialize the shortcut modal with available shortcuts.  Needs
     // to be done separately rather at construction, as many shortcuts
     // are not registered at that point.
     this.shortcutDialog.createModalContent();
@@ -734,6 +725,7 @@ export class NavigationController {
     this.insertAction.uninstall();
     this.clipboard.uninstall();
     this.workspaceMovement.uninstall();
+    this.shortcutDialog.uninstall();
 
     this.removeShortcutHandlers();
     this.navigation.dispose();

src/shortcut_dialog.ts

@@ -158,6 +158,31 @@ export class ShortcutDialog {
       }
     }
   }
+
+  /**
+   * Registers an action to list shortcuts with the shortcut registry.
+   */
+  install() {
+    /** List all of the currently registered shortcuts. */
+    const announceShortcut: ShortcutRegistry.KeyboardShortcut = {
+      name: Constants.SHORTCUT_NAMES.LIST_SHORTCUTS,
+      callback: () => {
+        this.toggle();
+        return true;
+      },
+      keyCodes: [Blockly.utils.KeyCodes.SLASH],
+    };
+    ShortcutRegistry.registry.register(announceShortcut);
+  }
+
+  /**
+   * Unregisters the action to list shortcuts.
+   */
+  uninstall() {
+    ShortcutRegistry.registry.unregister(
+      Constants.SHORTCUT_NAMES.LIST_SHORTCUTS,
+    );
+  }
 }
 
 /**