chore: remove unneeded non-null assertions

Now `setCurNode` can take null we don't need them.

Author: microbit-matt-hillsdon

src/actions/disconnect.ts

@@ -145,8 +145,7 @@ export class DisconnectAction {
     rootBlock.bringToFront();
 
     if (wasVisitingConnection) {
-      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-      const connectionNode = ASTNode.createConnectionNode(superiorConnection)!;
+      const connectionNode = ASTNode.createConnectionNode(superiorConnection);
       workspace.getCursor()?.setCurNode(connectionNode);
     }
   }

src/actions/enter.ts

@@ -145,8 +145,7 @@ export class EnterAction {
     }
 
     this.navigation.focusWorkspace(workspace);
-    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-    workspace.getCursor()?.setCurNode(ASTNode.createBlockNode(newBlock)!);
+    workspace.getCursor()?.setCurNode(ASTNode.createBlockNode(newBlock));
   }
 
   /**

src/actions/ws_movement.ts

@@ -115,11 +115,10 @@ export class WorkspaceMovement {
     const newY = yDirection * WS_MOVE_DISTANCE + wsCoord.y;
 
     cursor.setCurNode(
-      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
       ASTNode.createWorkspaceNode(
         workspace,
         new BlocklyUtils.Coordinate(newX, newY),
-      )!,
+      ),
     );
     return true;
   }

src/flyout_cursor.ts

@@ -83,12 +83,13 @@ export class FlyoutCursor extends Blockly.Cursor {
     return null;
   }
 
-  override setCurNode(node: Blockly.ASTNode) {
+  override setCurNode(node: Blockly.ASTNode | null) {
     super.setCurNode(node);
 
-    const location = node.getLocation();
+    const location = node?.getLocation();
     let bounds: Blockly.utils.Rect | undefined;
     if (
+      location &&
       'getBoundingRectangle' in location &&
       typeof location.getBoundingRectangle === 'function'
     ) {

src/line_cursor.ts

@@ -744,8 +744,7 @@ export class LineCursor extends Marker {
         block = block.getParent();
       }
       if (block) {
-        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-        this.setCurNode(Blockly.ASTNode.createBlockNode(block)!, true);
+        this.setCurNode(Blockly.ASTNode.createBlockNode(block), true);
       }
     }
   }

src/navigation.ts

@@ -320,8 +320,7 @@ export class Navigation {
       const curNode = cursor.getCurNode();
       const block = curNode ? curNode.getSourceBlock() : null;
       if (block && block.id === mutatedBlockId) {
-        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-        cursor.setCurNode(Blockly.ASTNode.createBlockNode(block)!);
+        cursor.setCurNode(Blockly.ASTNode.createBlockNode(block));
       }
     }
   }
@@ -348,11 +347,7 @@ export class Navigation {
 
     if (sourceBlock.id === deletedBlockId || ids.includes(sourceBlock.id)) {
       cursor.setCurNode(
-        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-        Blockly.ASTNode.createWorkspaceNode(
-          workspace,
-          WS_COORDINATE_ON_DELETE,
-        )!,
+        Blockly.ASTNode.createWorkspaceNode(workspace, WS_COORDINATE_ON_DELETE),
       );
     }
   }
@@ -374,8 +369,7 @@ export class Navigation {
     const curNodeBlock = block.isShadow() ? block : block.getParent();
     if (curNodeBlock) {
       this.getFlyoutCursor(mainWorkspace)?.setCurNode(
-        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-        Blockly.ASTNode.createStackNode(curNodeBlock)!,
+        Blockly.ASTNode.createStackNode(curNodeBlock),
       );
     }
     this.focusFlyout(mainWorkspace);
@@ -603,17 +597,15 @@ export class Navigation {
     if (!defaultFlyoutItem) return;
     const defaultFlyoutItemElement = defaultFlyoutItem.getElement();
     if (defaultFlyoutItemElement instanceof Blockly.FlyoutButton) {
-      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
       const astNode = Blockly.ASTNode.createButtonNode(
         defaultFlyoutItemElement as Blockly.FlyoutButton,
-      )!;
+      );
       flyoutCursor.setCurNode(astNode);
       return true;
     } else if (defaultFlyoutItemElement instanceof Blockly.BlockSvg) {
-      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
       const astNode = Blockly.ASTNode.createStackNode(
         defaultFlyoutItemElement as Blockly.BlockSvg,
-      )!;
+      );
       flyoutCursor.setCurNode(astNode);
       return true;
     }
@@ -652,17 +644,15 @@ export class Navigation {
     );
     if (topBlocks.length > 0) {
       cursor.setCurNode(
-        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
         Blockly.ASTNode.createTopNode(
           topBlocks[prefer === 'first' ? 0 : topBlocks.length - 1],
-        )!,
+        ),
       );
     } else {
-      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
       const wsNode = Blockly.ASTNode.createWorkspaceNode(
         workspace,
         wsCoordinates,
-      )!;
+      );
       cursor.setCurNode(wsNode);
     }
     return true;