feat: Deploy GH pages with screen reader experiment #689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I will put this in review once I can validate it on my fork (which will require #684 to be merged, first). |
BenHenning
commented
Aug 6, 2025
Collaborator
Author
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
Self-checked the code, and updated one line that was wrong.
…ryPiFoundation#684) Fixes part of RaspberryPiFoundation/blockly#3370 Fixes part of RaspberryPiFoundation/blockly#9283 This PR introduces the plugin corresponding changes needed by RaspberryPiFoundation/blockly#9280. In particular, this: - Introduces CI workflow updates so that "tip-of-tree" is redefined as the corresponding experimental branch in core for screen reader support (to ensure CI passes here for changes that happen there). - Removes some access error overrides since the corresponding field was made public in the core PR (which is the root of the CI failures here). - Introduces some general instructions in the navigation plugin playground for folks testing Blockly with a screen reader (and points to RaspberryPiFoundation#673 for discussion). **Important**: Note that this PR's changes will NOT be merged into the `main` branch as-is. They will be reconsidered entirely (and likely largely reimplemented) separately from this experimental branch and submitted as a separate, future review for `main`. See RaspberryPiFoundation/blockly#9280 and Fixes part of RaspberryPiFoundation/blockly#9283 for more specifics on why the separate branch thing is being set up this way.
…pages-deployment-for-screen-reader-experiment
Collaborator
Author
|
I've verified that this is working correctly in a fork: https://benhenning.github.io/blockly-keyboard-experimentation/screenreader/ deploys with BenHenning#4. I'll leave that live until this PR is ready to merge (since otherwise removing my direct change to my fork's |
BenHenning
commented
Aug 11, 2025
Collaborator
Author
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
Self-reviewed latest.
gonfunko
approved these changes
Aug 11, 2025
BenHenning
merged commit 9dac4bd
into
RaspberryPiFoundation:main
10 of 11 checks passed
BenHenning
deleted the
update-gh-pages-deployment-for-screen-reader-experiment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #686
This updates the GH pages workflow to:
mainandadd-screen-reader-support-experimental(the screen reader experimental branch--see Set up experimental branches for screen reader development blockly#9283)./screenreadersubdirectory in the plugin repo's GitHub pages deployment.This will approximately double the amount of time needed for the GH pages deployment since it requires building two distinct copies of core Blockly and the plugin (tip-of-tree versions and the screen reader experimentation versions).
Conveniently, this will act as a fast way to see screen reader changes since they will go live a few minutes after a change to the plugin. Unfortunately, that does not reciprocate for changes to core Blockly (where most of the screen reader changes will actually occur), so oftentimes a manual run of the workflow will be needed (which should suffice in those cases).
Note that this needs to be approached in this way (building and uploading both projects for changes to either branch) since the action being used for deployment doesn't support partial deployment. See: actions/deploy-pages#349.