Skip to content

fix!: delete ASTNode and references #9014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rachel-fenichel merged 1 commit into from
May 8, 2025
Merged

fix!: delete ASTNode and references #9014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions core/blockly.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,6 @@ import {
import {IVariableMap} from './interfaces/i_variable_map.js';
import {IVariableModel, IVariableState} from './interfaces/i_variable_model.js';
import * as internalConstants from './internal_constants.js';
import {ASTNode} from './keyboard_nav/ast_node.js';
import {CursorOptions, LineCursor} from './keyboard_nav/line_cursor.js';
import {Marker} from './keyboard_nav/marker.js';
import type {LayerManager} from './layer_manager.js';
Expand Down Expand Up @@ -447,7 +446,6 @@ export * from './toast.js';

// Re-export submodules that no longer declareLegacyNamespace.
export {
ASTNode,
Block,
BlockSvg,
BlocklyOptions,
Expand Down
336 changes: 0 additions & 336 deletions core/keyboard_nav/ast_node.ts
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion core/keyboard_nav/line_cursor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,7 @@ export class LineCursor extends Marker {
for (const node of nodes) {
if (
this.validNode(node) &&
!this.toASTNode(node)?.getSourceBlock()?.disposed
!this.getSourceBlockFromNode(node)?.disposed
) {
this.setCurNode(node);
return;
Expand Down
Loading