fix: normalize school_roll_number to uppercase before validation

Author: Mohamed-RPF

app/models/school.rb

@@ -108,8 +108,13 @@ def normalize_district_fields
   end
 
   # Ensure the school_roll_number is nil, not an empty string
+  # Also normalize to uppercase for consistent validation
   def normalize_school_roll_number
-    self.school_roll_number = nil if school_roll_number.blank?
+    if school_roll_number.blank?
+      self.school_roll_number = nil
+    else
+      self.school_roll_number = school_roll_number.upcase
+    end
   end
 
   def verified_at_cannot_be_changed

spec/models/school_spec.rb

@@ -196,6 +196,12 @@
       expect(school.school_roll_number).to be_nil
     end
 
+    it 'normalizes school_roll_number to uppercase' do
+      school.school_roll_number = '01572d'
+      school.save
+      expect(school.school_roll_number).to eq('01572D')
+    end
+
     it 'requires an address_line_1' do
       school.address_line_1 = ' '
       expect(school).not_to be_valid