Fix plugin sidebar panel rerender issues #1279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loiswells97
temporarily deployed
to
previews/1279/merge
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses rerendering issues with plugin sidebar panels by wrapping the plugin menu options mapping in a useMemo hook to memoize the result and prevent unnecessary recreations on every render.
Key changes:
- Wrapped the
pluginMenuOptionscreation withuseMemoto memoize the plugin menu options array - Added
useMemoto the React imports in Sidebar.jsx
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/components/Menus/Sidebar/Sidebar.jsx | Wrapped plugin menu options mapping in useMemo to prevent unnecessary recreations |
| CHANGELOG.md | Documented the fix for plugin sidebar panel rerendering issue |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jamiebenstead
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/RaspberryPiFoundation/digital-editor-issues/issues/970