Skip to content

Commit dc1f4f9

Browse files
authored
Removes v1_signup param (#62)
No longer needed, since we now assume all log in / sign ups to Profile should use the v1 flow (since migrating fully to Hydra v1). Depends on: RaspberryPiFoundation/profile#1512
2 parents 0660415 + d6f9608 commit dc1f4f9

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

config/routes.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
# Dummy routes. These routes are never reached in the app, as Omniauth
55
# intercepts it via Rack middleware before it reaches Rails, however adding
66
# them allows us to use rpi_auth_login_path helpers etc.
7-
post RpiAuth::Engine::LOGIN_PATH, as: :rpi_auth_login, params: { login_options: 'v1_signup' }
8-
post RpiAuth::Engine::LOGIN_PATH, as: :rpi_auth_signup, params: { login_options: 'force_signup,v1_signup' }
7+
post RpiAuth::Engine::LOGIN_PATH, as: :rpi_auth_login
8+
post RpiAuth::Engine::LOGIN_PATH, as: :rpi_auth_signup, params: { login_options: 'force_signup' }
99

1010
get RpiAuth::Engine::CALLBACK_PATH, to: 'rpi_auth/auth#callback', as: 'rpi_auth_callback'
1111
get RpiAuth::Engine::LOGOUT_PATH, to: 'rpi_auth/auth#destroy', as: 'rpi_auth_logout'

spec/dummy/spec/views/home_show_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@
1717

1818
it 'shows the correct log in link' do
1919
render
20-
expect(html.search('form[action="/auth/rpi?login_options=v1_signup"]')).not_to be_empty
20+
expect(html.search('form[action="/auth/rpi"]')).not_to be_empty
2121
end
2222

2323
it 'shows the sign up link' do
2424
render
25-
expect(html.search('form[action="/auth/rpi?login_options=force_signup%2Cv1_signup"]')).not_to be_empty
25+
expect(html.search('form[action="/auth/rpi?login_options=force_signup"]')).not_to be_empty
2626
end
2727
end
2828

0 commit comments

Comments
 (0)