-
-
Notifications
You must be signed in to change notification settings - Fork 53
Additional stock MK3S hardware support #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
| display_beeper_pin=PH2, | ||
|
|
||
|
|
||
| [temperature_sensor einsy] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work in 2.1, the configurator only uses this file to read the board alias map. You can put it in the template, commented out, like you did with the display backlight pin. It's ugly, but there's no other way to do non-standard things currently.
| display_encoder_pin1=PJ1, | ||
| display_encoder_pin2=PJ2, | ||
| display_click_pin=PH6, | ||
| display_backlight_pin=PE3, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a standard pin alias (neither are the other display_* aliases, they aren't used, they're only there for backwards compatibility with 2.0 configs) and will be ignored by the configurator. Remove it.
| encoder_pins: ^display_encoder_pin1,^display_encoder_pin2 | ||
| click_pin: ^!display_click_pin | ||
|
|
||
| [output_pin LCD_backlight_pin] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section should be removed. RatOS currently has no concept of lcd displays. There's a feature in development to allow for "accessories" to support arbitrary things like this, until then it will have to be a commented out section in the printer.cfg template.
| shutdown_value: 1 | ||
| cycle_time: 0.001 | ||
|
|
||
| [output_pin BEEPER_pin] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar for this actually, this should also be removed (or moved to the printer template)
| id: 'BONDTECH-42H025H-0704-002', | ||
| title: 'Bondtech LGX Stepper', | ||
| maxPeakCurrent: 0.7, | ||
| presets: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do these values come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the datasheet for the motor itself, and referencing other klipper configurations for the MK3S they appear to be referencing the datasheet as well
|
my machine actually kicked the bucket, something up with my hotend so I won't be able to make adjustments or test this further, but hopefully some of it is helpful |
Added LCD backlight control and Einsy board temperature sensor