Skip to content

Commit 3054932

Browse files
committed
clean up
1 parent eab6953 commit 3054932

File tree

1 file changed

+3
-29
lines changed

1 file changed

+3
-29
lines changed

armsrc/mifareutil.c

Lines changed: 3 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -544,10 +544,7 @@ int mifare_ultra_aes_auth(uint8_t keyno, uint8_t *keybytes, bool schann) {
544544
return 1;
545545
}
546546

547-
// Session key calculation
548-
if (g_dbglevel >= DBG_DEBUG) {
549-
DbpString("");
550-
}
547+
// Session key calculation setion
551548

552549
// clear global session variable
553550
init_secure_session();
@@ -602,14 +599,6 @@ static int mifare_ultra_readblockEx(uint8_t blockNo, uint8_t *blockData) {
602599
ulaes_cmac(sobj->sessionkey, sizeof(sobj->sessionkey), cmd_mac, 4, mac);
603600
ulaes_cmac8(mac, cmd_mac + 4);
604601

605-
if (g_dbglevel >= DBG_DEBUG) {
606-
print_result("cntr || cmd...", cmd_mac, 4);
607-
print_result("session key...", sobj->sessionkey, 16);
608-
print_result("session mac...", mac, 16);
609-
print_result("calc cmac.....", cmd_mac, sizeof(cmd_mac));
610-
print_result("session cmd data", cmd_mac + 4, 8);
611-
}
612-
613602
increase_session_counter();
614603

615604
len = mifare_sendcmd_schann(cmd_mac + 2, sizeof(cmd_mac) - 2, receivedAnswer, sizeof(receivedAnswer), receivedAnswerPar, NULL);
@@ -643,7 +632,8 @@ static int mifare_ultra_readblockEx(uint8_t blockNo, uint8_t *blockData) {
643632
return PM3_ECRC;
644633
}
645634

646-
// we are skipping verifying the cmac, since we don't care.
635+
// we are skipping verifying the cmac since we don't care.
636+
647637
// increase counter for the read response
648638
increase_session_counter();
649639

@@ -836,14 +826,6 @@ int mifare_ultra_writeblock(uint8_t blockNo, uint8_t *blockData) {
836826
if (sobj->use_schann) {
837827

838828
uint8_t mac[16] = {0};
839-
/*
840-
2b counter
841-
1b cmd
842-
1b blockno
843-
4b data
844-
8b cmac
845-
2b crc --> not included
846-
*/
847829
uint8_t cmd_mac[2 + 1 + 1 + 4 + 8] = {
848830
sobj->counter & 0xFF,
849831
(sobj->counter >> 8) & 0xFF,
@@ -855,14 +837,6 @@ int mifare_ultra_writeblock(uint8_t blockNo, uint8_t *blockData) {
855837
ulaes_cmac(sobj->sessionkey, sizeof(sobj->sessionkey), cmd_mac, 8, mac);
856838
ulaes_cmac8(mac, cmd_mac + 8);
857839

858-
if (g_dbglevel >= DBG_DEBUG) {
859-
print_result("cntr || cmd...", cmd_mac, 8);
860-
print_result("session key...", sobj->sessionkey, 16);
861-
print_result("session mac...", mac, 16);
862-
print_result("calc cmac.....", cmd_mac, sizeof(cmd_mac));
863-
print_result("session cmd data", cmd_mac + 8, 8);
864-
}
865-
866840
increase_session_counter();
867841

868842
len = mifare_sendcmd_schann(cmd_mac + 2, sizeof(cmd_mac) - 2, receivedAnswer, sizeof(receivedAnswer), receivedAnswerPar, NULL);

0 commit comments

Comments
 (0)