Merge pull request #2984 from jmichelp/patch-5

iceman1001 · web-flow · commit 5b8bd31d17c0 · 2025-09-21T23:10:28.000+02:00
Fix data being xored twice
diff --git a/client/src/cmdhflegic.c b/client/src/cmdhflegic.c
@@ -300,9 +300,9 @@ static int decode_and_print_memory(uint16_t card_size, const uint8_t *input_buff
                 // does this one work? (Answer: Only if KGH/BGH is used with BCD encoded card number! So maybe this will show just garbage...)
                 if (wrp_len == 8) {
                     PrintAndLogEx(SUCCESS, "Card ID: " _YELLOW_("%2X%02X%02X"),
-                                  data[i - 4] ^ crc,
-                                  data[i - 3] ^ crc,
-                                  data[i - 2] ^ crc
+                                  data[i - 4],
+                                  data[i - 3],
+                                  data[i - 2]
                                  );
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -300,9 +300,9 @@ static int decode_and_print_memory(uint16_t card_size, const uint8_t *input_buff`
`300`	`300`	`// does this one work? (Answer: Only if KGH/BGH is used with BCD encoded card number! So maybe this will show just garbage...)`
`301`	`301`	`if (wrp_len == 8) {`
`302`	`302`	`PrintAndLogEx(SUCCESS, "Card ID: " _YELLOW_("%2X%02X%02X"),`
`303`		`- data[i - 4] ^ crc,`
`304`		`- data[i - 3] ^ crc,`
`305`		`- data[i - 2] ^ crc`
	`303`	`+ data[i - 4],`
	`304`	`+ data[i - 3],`
	`305`	`+ data[i - 2]`
`306`	`306`	`);`
`307`	`307`	`}`
`308`	`308`	`}`