Merge pull request #3043 from aaronjamt/patch-1

iceman1001 · web-flow · commit 984a92d88da7 · 2025-12-11T13:25:41.000+01:00
[hf seos] Carry when incrementing
diff --git a/client/src/cmdhfseos.c b/client/src/cmdhfseos.c
@@ -163,7 +163,11 @@ static int decrypt_cryptogram(uint8_t *key, uint8_t *input, uint8_t *out, int in
 }
 
 static void increment_command_wrapper(uint8_t *input, int input_len) {
-    input[input_len - 1]++; // Increment the last element of the header by 1
+    // Increment the end of the header by 1
+    uint8_t* offset = &input[input_len - sizeof(uint32_t)];
+    uint32_t value = MemBeToUint4byte(offset);
+    value++;
+    Uint4byteToMemBe(offset, value);
 }
 
 static void padToBlockSize(const uint8_t *input, int *inputSize, int blockSize, uint8_t *output) {

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,11 @@ static int decrypt_cryptogram(uint8_t key, uint8_t input, uint8_t *out, int in`
`163`	`163`	`}`
`164`	`164`
`165`	`165`	`static void increment_command_wrapper(uint8_t *input, int input_len) {`
`166`		`- input[input_len - 1]++; // Increment the last element of the header by 1`
	`166`	`+ // Increment the end of the header by 1`
	`167`	`+ uint8_t* offset = &input[input_len - sizeof(uint32_t)];`
	`168`	`+ uint32_t value = MemBeToUint4byte(offset);`
	`169`	`+ value++;`
	`170`	`+ Uint4byteToMemBe(offset, value);`
`167`	`171`	`}`
`168`	`172`
`169`	`173`	`static void padToBlockSize(const uint8_t input, int inputSize, int blockSize, uint8_t *output) {`