Skip to content

Commit 1d75f80

Browse files
committed
BUG: do not warn for rockets without parachute
Only warn if motor or aerodynamic surfaces are missing. Never raise a warning for no parachute. See #285
1 parent c00e2dd commit 1d75f80

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

rocketpy/rocket/rocket.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,6 @@ def _check_missing_components(self):
389389
390390
This method verifies whether the rocket has the following key components:
391391
- motor
392-
- parachute(s)
393392
- aerodynamic surface(s)
394393
395394
If any of these components are missing, a single warning message is issued
@@ -402,8 +401,6 @@ def _check_missing_components(self):
402401
missing_components = []
403402
if isinstance(self.motor, EmptyMotor):
404403
missing_components.append("motor")
405-
if not self.parachutes:
406-
missing_components.append("parachutes")
407404
if not self.aerodynamic_surfaces or len(self.aerodynamic_surfaces) == 0:
408405
missing_components.append("aerodynamic surfaces")
409406

0 commit comments

Comments
 (0)