Skip to content

Conversation

@osalbahr
Copy link

@osalbahr osalbahr commented Nov 5, 2025

Thank you for making Rust GCC better!

If your PR fixes an issue, you can add "Fixes #issue_number" into this
PR description and the git commit message. This way the issue will be
automatically closed when your PR is merged. If your change addresses
an issue but does not fully fix it please mark it as "Addresses #issue_number"
in the git commit message.

Here is a checklist to help you with your PR.

  • GCC development requires copyright assignment or the Developer's Certificate of Origin sign-off, see https://gcc.gnu.org/contribute.html or https://gcc.gnu.org/dco.html
  • Read contributing guidlines
  • make check-rust passes locally (N/A)
  • Run clang-format (N/A)
  • Added any relevant test cases to gcc/testsuite/rust/ (N/A)

Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.

This commit adds dependencies needed for ../gccrs/configure --prefix=$HOME/gccrs-install --disable-bootstrap --enable-multilib --enable-languages=rust (from the README) in a fresh FedoraLinux-43 WSL. Most are also needed in a fedora container (the exception is awk; it's present in the container but not WSL).

In other words, this commit fixes the following configure errors (truncated and combined):

configure: error: no acceptable C compiler found in $PATH
configure: error: *** A compiler with support for C++14 language features is required.
configure: error: cargo is required to build rust
./config.status: line 1194: awk: command not found

The goal is to eventually package gccrs in Copr (Fedora's AUR). Finding all the dependencies is a first step.

Signed-off-by: Osama Albahrani <[email protected]>

@osalbahr
Copy link
Author

osalbahr commented Nov 5, 2025

Running make in the container, I also got:

/bin/sh: line 1: cmp: command not found

At the end. Not sure if that (diffutils) should also be added.

It seems to build fine in WSL.

Copy link
Member

@philberty philberty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cant remove the README

@osalbahr osalbahr force-pushed the configure-in-fedora-wsl branch from 7faa1de to 97e2de7 Compare November 9, 2025 22:05
@osalbahr
Copy link
Author

osalbahr commented Nov 9, 2025

Oops. I'm not sure how that happened. I used GitHub's web VS Code UI to edit README.md only.

Anyways, I just revived README.

Copy link
Member

@philberty philberty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philberty
Copy link
Member

You need to fix your commit message to pass our commit checker. you can use the tools to setup git gcc-commit-mklog in contrib

ChangeLog:

	* README.md: Add Fedora WSL deps.

Signed-off-by: Osama Albahrani <[email protected]>
@osalbahr osalbahr force-pushed the configure-in-fedora-wsl branch from 97e2de7 to 6aa1fba Compare November 10, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants