Merge pull request #1 from AydinHassan/fix-bitwise-checks

Fix bitwise tests + add unit tests

Author: davidwdan

composer.json

@@ -42,6 +42,6 @@
     "rx/child-process": "^1.0"
   },
   "require-dev": {
-    "phpunit/phpunit": "^5.7"
+    "phpunit/phpunit": "^6.2"
   }
 }

phpunit.xml

@@ -9,10 +9,10 @@
         processIsolation="false"
         stopOnFailure="false"
         syntaxCheck="false"
-        bootstrap="tests/bootstrap.php">
+        bootstrap="test/bootstrap.php">
     <testsuites>
         <testsuite name="Rx/FsWatch Tests">
-            <directory>tests/</directory>
+            <directory>test/</directory>
         </testsuite>
     </testsuites>
 

src/WatchEvent.php

@@ -58,56 +58,56 @@ public function getEvents()
 
     public function isFile()
     {
-        return (bool)$this->bitwise & self::IS_FILE;
+        return (bool) ($this->bitwise & self::IS_FILE);
     }
 
     public function isDir()
     {
-        return (bool)$this->bitwise & self::IS_DIR;
+        return (bool) ($this->bitwise & self::IS_DIR);
     }
 
     public function isSymbolicLink()
     {
-        return (bool)$this->bitwise & self::IS_SYM_LINK;
+        return (bool) ($this->bitwise & self::IS_SYM_LINK);
     }
 
     public function isLink()
     {
-        return (bool)$this->bitwise & self::LINK;
+        return (bool) ($this->bitwise & self::LINK);
     }
 
     public function noOp()
     {
-        return (bool)$this->bitwise & self::NO_OP;
+        return (bool) ($this->bitwise & self::NO_OP);
     }
 
     public function attributeModified()
     {
-        return (bool)$this->bitwise & self::ATTRIBUTE_MODIFIED;
+        return (bool) ($this->bitwise & self::ATTRIBUTE_MODIFIED);
     }
 
     public function ownerModified()
     {
-        return (bool)$this->bitwise & self::OWNER_MODIFIED;
+        return (bool) ($this->bitwise & self::OWNER_MODIFIED);
     }
 
     public function created()
     {
-        return (bool)$this->bitwise & self::CREATED;
+        return (bool) ($this->bitwise & self::CREATED);
     }
 
     public function removed()
     {
-        return (bool)$this->bitwise & self::REMOVED;
+        return (bool) ($this->bitwise & self::REMOVED);
     }
 
     public function renamed()
     {
-        return (bool)$this->bitwise & self::RENAMED;
+        return (bool) ($this->bitwise & self::RENAMED);
     }
 
     public function updated()
     {
-        return (bool)$this->bitwise & self::UPDATED;
+        return (bool) ($this->bitwise & self::UPDATED);
     }
 }

test/Rx/WatchEventTest.php

@@ -0,0 +1,95 @@
+<?php
+
+namespace  Rx\React\Tests;
+
+use PHPUnit\Framework\TestCase;
+use Rx\React\WatchEvent;
+
+/**
+ * @author Aydin Hassan <[email protected]>
+ */
+class WatchEventTest extends TestCase
+{
+    public function testFileCreated()
+    {
+        $e = new WatchEvent('/some/file.txt', 514);
+
+        self::assertTrue($e->created());
+        self::assertEquals('/some/file.txt', $e->getFile());
+        self::assertEquals(514, $e->getBitwise());
+    }
+
+    public function testFileUpdated()
+    {
+        $e = new WatchEvent('/some/file.txt', 516);
+
+        self::assertTrue($e->updated());
+        self::assertEquals('/some/file.txt', $e->getFile());
+        self::assertEquals(516, $e->getBitwise());
+    }
+
+    public function testFileRenamed()
+    {
+        $e = new WatchEvent('/some/file.txt', 528);
+
+        self::assertTrue($e->renamed());
+        self::assertEquals('/some/file.txt', $e->getFile());
+        self::assertEquals(528, $e->getBitwise());
+    }
+
+    public function testFileRemoved()
+    {
+        $e = new WatchEvent('/some/file.txt', 520);
+
+        self::assertTrue($e->removed());
+        self::assertEquals('/some/file.txt', $e->getFile());
+        self::assertEquals(520, $e->getBitwise());
+    }
+
+    public function testFileOwnerModified()
+    {
+        $e = new WatchEvent('/some/file.txt', 544);
+
+        self::assertTrue($e->ownerModified());
+        self::assertEquals('/some/file.txt', $e->getFile());
+        self::assertEquals(544, $e->getBitwise());
+    }
+
+    public function testFileAttributeModified()
+    {
+        $e = new WatchEvent('/some/file.txt', 576);
+
+        self::assertTrue($e->attributeModified());
+        self::assertEquals('/some/file.txt', $e->getFile());
+        self::assertEquals(576, $e->getBitwise());
+    }
+
+    public function testFileIsLink()
+    {
+        $e = new WatchEvent('/some/file.txt', 4608);
+
+        self::assertTrue($e->isFile());
+        self::assertTrue($e->isLink());
+        self::assertEquals('/some/file.txt', $e->getFile());
+        self::assertEquals(4608, $e->getBitwise());
+    }
+
+    public function testFileIsSymbolicLink()
+    {
+        $e = new WatchEvent('/some/file.txt', 2560);
+
+        self::assertTrue($e->isFile());
+        self::assertTrue($e->isSymbolicLink());
+        self::assertEquals('/some/file.txt', $e->getFile());
+        self::assertEquals(2560, $e->getBitwise());
+    }
+
+    public function testDir()
+    {
+        $e = new WatchEvent('/some/dir', 1024);
+
+        self::assertTrue($e->isDir());
+        self::assertEquals('/some/dir', $e->getFile());
+        self::assertEquals(1024, $e->getBitwise());
+    }
+}