Modified how types are exposed and modified tests

Author: BrigittaK307

packages/orchestration/src/orchestration-types.ts

@@ -26,8 +26,7 @@ import type {
   EmbeddingsModelDetails as OriginalEmbeddingsModelDetails,
   EmbeddingsModelParams as OriginalEmbeddingsModelParams,
   SAPDocumentTranslationInput,
-  SAPDocumentTranslationOutput,
-  SAPDocumentTranslationApplyToSelector
+  SAPDocumentTranslationOutput
 } from './client/api/schema/index.js';
 
 /**
@@ -426,11 +425,33 @@ export type LlamaGuard38BCategory = keyof LlamaGuard38B;
  */
 export type ConfigType = 'input' | 'output';
 
+/**
+ * Category for translation application scope.
+ */
+export type TranslationApplyToCategory = 'placeholders' | 'template_roles';
+
 /**
  * Configuration selector for applying translation to specific placeholders or message roles.
  */
-export type DocumentTranslationApplyToSelector =
-  SAPDocumentTranslationApplyToSelector;
+export interface DocumentTranslationApplyToSelector {
+  /**
+   * Category to apply translation to.
+   */
+  category: TranslationApplyToCategory;
+  /**
+   * List of placeholders or roles to apply translation to.
+   * @example [
+   *   "groundingInput",
+   *   "inputContext"
+   * ]
+   */
+  items: string[];
+  /**
+   * Language of the text to be translated.
+   * @example "de-DE"
+   */
+  sourceLanguage?: string;
+}
 
 /**
  * Target language for translation, either a language code or a selector configuration.
@@ -460,7 +481,7 @@ interface TranslationConfigParametersInput {
   translateMessagesHistory?: boolean;
   /**
    * Configuration for applying translation to specific placeholders or message roles.
-   * @example applyTo: [{ category: 'placeholders', items: ['user_input'], source_language: 'de-DE' }]
+   * @example applyTo: [{ category: 'placeholders', items: ['user_input'], sourceLanguage: 'de-DE' }]
    */
   applyTo?: DocumentTranslationApplyToSelector[];
 }

packages/orchestration/src/util/translation.test.ts

@@ -49,7 +49,7 @@ describe('Translation module config', () => {
         {
           category: 'placeholders',
           items: ['user_input'],
-          source_language: 'de-DE'
+          sourceLanguage: 'de-DE'
         }
       ]
     });

packages/orchestration/src/util/translation.ts

@@ -1,10 +1,24 @@
+import type { SAPDocumentTranslationApplyToSelector } from '../client/api/schema/index.js';
 import type {
   TranslationConfigParams,
   TranslationReturnType,
   ConfigType,
-  TranslationInputParameters
+  TranslationInputParameters,
+  DocumentTranslationApplyToSelector
 } from '../orchestration-types.js';
 
+function mapSelectorToBaseType(
+  selector: DocumentTranslationApplyToSelector
+): SAPDocumentTranslationApplyToSelector {
+  return {
+    category: selector.category,
+    items: selector.items,
+    ...(selector.sourceLanguage && {
+      source_language: selector.sourceLanguage
+    })
+  };
+}
+
 /**
  * Convenience function to build a document translation configuration for orchestration service.
  * @param type - Type of the translation configuration, either `input` or `output`.
@@ -20,13 +34,6 @@ export function buildTranslationConfig<T extends ConfigType>(
   type: T,
   config: TranslationConfigParams<T>
 ): TranslationReturnType<T> {
-  const baseConfig = {
-    ...(config.sourceLanguage && {
-      source_language: config.sourceLanguage
-    }),
-    target_language: config.targetLanguage
-  };
-
   if (type === 'input') {
     const inputConfig = config as TranslationInputParameters;
     return {
@@ -35,16 +42,27 @@ export function buildTranslationConfig<T extends ConfigType>(
         translate_messages_history: inputConfig.translateMessagesHistory
       }),
       config: {
-        ...baseConfig,
+        ...(inputConfig.sourceLanguage && {
+          source_language: inputConfig.sourceLanguage
+        }),
+        target_language: inputConfig.targetLanguage,
         ...(inputConfig.applyTo && {
-          apply_to: inputConfig.applyTo
+          apply_to: inputConfig.applyTo.map(mapSelectorToBaseType)
         })
       }
     } as TranslationReturnType<T>;
   }
 
   return {
     type: 'sap_document_translation',
-    config: baseConfig
+    config: {
+      ...(config.sourceLanguage && {
+        source_language: config.sourceLanguage
+      }),
+      target_language:
+        typeof config.targetLanguage === 'string'
+          ? config.targetLanguage
+          : mapSelectorToBaseType(config.targetLanguage)
+    }
   } as TranslationReturnType<T>;
 }

sample-code/src/orchestration.ts

@@ -750,7 +750,7 @@ export async function orchestrationTranslation(): Promise<OrchestrationResponse>
           {
             category: 'placeholders',
             items: ['user_input'],
-            source_language: 'en-US'
+            sourceLanguage: 'en-US'
           }
         ]
       }),